* [PATCH] soundwire: qcom: Constify static structs
@ 2020-06-09 23:00 Rikard Falkeborn
2020-06-22 11:58 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Rikard Falkeborn @ 2020-06-09 23:00 UTC (permalink / raw)
Cc: agross, bjorn.andersson, vkoul, sanyog.r.kale,
pierre-louis.bossart, linux-arm-msm, alsa-devel, linux-kernel,
Rikard Falkeborn
qcom_swrm_port_ops and qcom_swrm_ops are not modified and can be made
const to allow the compiler to put them in read-only memory.
Before:
text data bss dec hex filename
18266 3056 256 21578 544a drivers/soundwire/qcom.o
After:
text data bss dec hex filename
18426 2896 256 21578 544a drivers/soundwire/qcom.o
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/soundwire/qcom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index a1c2a44a3b4d..915c2cf0c274 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -406,13 +406,13 @@ static int qcom_swrm_port_enable(struct sdw_bus *bus,
return ctrl->reg_write(ctrl, reg, val);
}
-static struct sdw_master_port_ops qcom_swrm_port_ops = {
+static const struct sdw_master_port_ops qcom_swrm_port_ops = {
.dpn_set_port_params = qcom_swrm_port_params,
.dpn_set_port_transport_params = qcom_swrm_transport_params,
.dpn_port_enable_ch = qcom_swrm_port_enable,
};
-static struct sdw_master_ops qcom_swrm_ops = {
+static const struct sdw_master_ops qcom_swrm_ops = {
.xfer_msg = qcom_swrm_xfer_msg,
.pre_bank_switch = qcom_swrm_pre_bank_switch,
};
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] soundwire: qcom: Constify static structs
2020-06-09 23:00 [PATCH] soundwire: qcom: Constify static structs Rikard Falkeborn
@ 2020-06-22 11:58 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-06-22 11:58 UTC (permalink / raw)
To: Rikard Falkeborn
Cc: Srinivas Kandagatla, agross, bjorn.andersson, sanyog.r.kale,
pierre-louis.bossart, linux-arm-msm, alsa-devel, linux-kernel
On 10-06-20, 01:00, Rikard Falkeborn wrote:
> qcom_swrm_port_ops and qcom_swrm_ops are not modified and can be made
> const to allow the compiler to put them in read-only memory.
>
> Before:
> text data bss dec hex filename
> 18266 3056 256 21578 544a drivers/soundwire/qcom.o
>
> After:
> text data bss dec hex filename
> 18426 2896 256 21578 544a drivers/soundwire/qcom.o
Applied, thanks
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/soundwire/qcom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index a1c2a44a3b4d..915c2cf0c274 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -406,13 +406,13 @@ static int qcom_swrm_port_enable(struct sdw_bus *bus,
> return ctrl->reg_write(ctrl, reg, val);
> }
>
> -static struct sdw_master_port_ops qcom_swrm_port_ops = {
> +static const struct sdw_master_port_ops qcom_swrm_port_ops = {
> .dpn_set_port_params = qcom_swrm_port_params,
> .dpn_set_port_transport_params = qcom_swrm_transport_params,
> .dpn_port_enable_ch = qcom_swrm_port_enable,
> };
>
> -static struct sdw_master_ops qcom_swrm_ops = {
> +static const struct sdw_master_ops qcom_swrm_ops = {
> .xfer_msg = qcom_swrm_xfer_msg,
> .pre_bank_switch = qcom_swrm_pre_bank_switch,
> };
> --
> 2.27.0
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-22 11:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-09 23:00 [PATCH] soundwire: qcom: Constify static structs Rikard Falkeborn
2020-06-22 11:58 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®