* [PATCH] [net/decnet] dn_route_rcv: remove redundant dev null check
@ 2020-06-23 3:41 Gaurav Singh
2020-06-24 3:27 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Gaurav Singh @ 2020-06-23 3:41 UTC (permalink / raw)
To: gaurav1086, David S. Miller, Jakub Kicinski, David Ahern,
David Laight, Guillaume Nault, Hangbin Liu,
open list:DECnet NETWORK LAYER, open list:NETWORKING [GENERAL],
open list
dev cannot be NULL here since its already being accessed
before. Remove the redundant null check.
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
---
net/decnet/dn_route.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
index 06b9983325cc..9eb7e4b62d9b 100644
--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -670,7 +670,7 @@ int dn_route_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type
if (decnet_debug_level & 1)
printk(KERN_DEBUG
"dn_route_rcv: got 0x%02x from %s [%d %d %d]\n",
- (int)flags, (dev) ? dev->name : "???", len, skb->len,
+ (int)flags, dev->name, len, skb->len,
padlen);
if (flags & DN_RT_PKT_CNTL) {
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [net/decnet] dn_route_rcv: remove redundant dev null check
2020-06-23 3:41 [PATCH] [net/decnet] dn_route_rcv: remove redundant dev null check Gaurav Singh
@ 2020-06-24 3:27 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-06-24 3:27 UTC (permalink / raw)
To: gaurav1086
Cc: kuba, dsahern, David.Laight, gnault, liuhangbin,
linux-decnet-user, netdev, linux-kernel
From: Gaurav Singh <gaurav1086@gmail.com>
Date: Mon, 22 Jun 2020 23:41:19 -0400
> dev cannot be NULL here since its already being accessed
> before. Remove the redundant null check.
>
> Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-24 3:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-23 3:41 [PATCH] [net/decnet] dn_route_rcv: remove redundant dev null check Gaurav Singh
2020-06-24 3:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®