[PATCH] net: sched: Allow changing default qdisc to FQ-PIE

[PATCH] net: sched: Allow changing default qdisc to FQ-PIE

[Danny Lin]

Similar to fq_codel and the other qdiscs that can set as default,
fq_pie is also suitable for general use without explicit configuration,
which makes it a valid choice for this.

This is useful in situations where a painless out-of-the-box solution
for reducing bufferbloat is desired but fq_codel is not necessarily the
best choice. For example, fq_pie can be better for DASH streaming, but
there could be more cases where it's the better choice of the two simple
AQMs available in the kernel.

Signed-off-by: Danny Lin <danny@kdrag0n.dev>
---
 net/sched/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/net/sched/Kconfig b/net/sched/Kconfig
index 84badf00647e..a3b37d88800e 100644
--- a/net/sched/Kconfig
+++ b/net/sched/Kconfig
@@ -468,6 +468,9 @@ choice
 	config DEFAULT_FQ_CODEL
 		bool "Fair Queue Controlled Delay" if NET_SCH_FQ_CODEL
 
+	config DEFAULT_FQ_PIE
+		bool "Flow Queue Proportional Integral controller Enhanced" if NET_SCH_FQ_PIE
+
 	config DEFAULT_SFQ
 		bool "Stochastic Fair Queue" if NET_SCH_SFQ
 
@@ -480,6 +483,7 @@ config DEFAULT_NET_SCH
 	default "pfifo_fast" if DEFAULT_PFIFO_FAST
 	default "fq" if DEFAULT_FQ
 	default "fq_codel" if DEFAULT_FQ_CODEL
+	default "fq_pie" if DEFAULT_FQ_PIE
 	default "sfq" if DEFAULT_SFQ
 	default "pfifo_fast"
 endif
-- 
2.27.0

Re: [PATCH] net: sched: Allow changing default qdisc to FQ-PIE

[David Miller]

From: Danny Lin <danny@kdrag0n.dev>
Date: Wed,  1 Jul 2020 16:01:52 -0700

> Similar to fq_codel and the other qdiscs that can set as default,
> fq_pie is also suitable for general use without explicit configuration,
> which makes it a valid choice for this.
> 
> This is useful in situations where a painless out-of-the-box solution
> for reducing bufferbloat is desired but fq_codel is not necessarily the
> best choice. For example, fq_pie can be better for DASH streaming, but
> there could be more cases where it's the better choice of the two simple
> AQMs available in the kernel.
> 
> Signed-off-by: Danny Lin <danny@kdrag0n.dev>

Applied to net-next, thank you.