From: David Miller <davem@davemloft.net>
To: frank-w@public-files.de
Cc: linux-mediatek@lists.infradead.org, opensource@vdorst.com,
nbd@nbd.name, john@phrozen.org, sean.wang@mediatek.com,
Mark-MC.Lee@mediatek.com, kuba@kernel.org,
matthias.bgg@gmail.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: mtk_eth_soc: fix mtu warning
Date: Wed, 08 Jul 2020 12:36:46 -0700 (PDT) [thread overview]
Message-ID: <20200708.123646.545653837566811385.davem@davemloft.net> (raw)
In-Reply-To: <20200708154634.9565-1-frank-w@public-files.de>
From: Frank Wunderlich <frank-w@public-files.de>
Date: Wed, 8 Jul 2020 17:46:34 +0200
> From: René van Dorst <opensource@vdorst.com>
>
> in recent Kernel-Versions there are warnings about incorrect MTU-Size
> like these:
>
> mt7530 mdio-bus:00: nonfatal error -95 setting MTU on port x
> eth0: mtu greater than device maximum
> mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead
>
> Signed-off-by: René van Dorst <opensource@vdorst.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>
> Fixes: bfcb813203 ("net: dsa: configure the MTU for switch ports")
> Fixes: 72579e14a1 ("net: dsa: don't fail to probe if we couldn't set the MTU")
> Fixes: 7a4c53bee3 ("net: report invalid mtu value via netlink extack")
In addition to the other Fixes: tag problems pointed out so far, you should
always put the Fixes: tags first, and immediately before the other tags
such as Signed-off-by: etc. and with no empty lines separating them.
Thank you.
prev parent reply other threads:[~2020-07-08 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 15:46 Frank Wunderlich
2020-07-08 16:32 ` Jakub Kicinski
2020-07-08 19:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708.123646.545653837566811385.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Mark-MC.Lee@mediatek.com \
--cc=frank-w@public-files.de \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=opensource@vdorst.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®