* [PATCH] net: ethernet: mtk_eth_soc: fix mtu warning
@ 2020-07-08 15:46 Frank Wunderlich
2020-07-08 16:32 ` Jakub Kicinski
2020-07-08 19:36 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Frank Wunderlich @ 2020-07-08 15:46 UTC (permalink / raw)
To: linux-mediatek
Cc: René van Dorst, Felix Fietkau, John Crispin, Sean Wang,
Mark Lee, David S. Miller, Jakub Kicinski, Matthias Brugger,
netdev, linux-arm-kernel, linux-kernel, Frank Wunderlich
From: René van Dorst <opensource@vdorst.com>
in recent Kernel-Versions there are warnings about incorrect MTU-Size
like these:
mt7530 mdio-bus:00: nonfatal error -95 setting MTU on port x
eth0: mtu greater than device maximum
mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead
Signed-off-by: René van Dorst <opensource@vdorst.com>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Fixes: bfcb813203 ("net: dsa: configure the MTU for switch ports")
Fixes: 72579e14a1 ("net: dsa: don't fail to probe if we couldn't set the MTU")
Fixes: 7a4c53bee3 ("net: report invalid mtu value via netlink extack")
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 85735d32ecb0..00e3d70f7d07 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -2891,6 +2891,10 @@ static int mtk_add_mac(struct mtk_eth *eth, struct device_node *np)
eth->netdev[id]->irq = eth->irq[0];
eth->netdev[id]->dev.of_node = np;
+ eth->netdev[id]->mtu = 1536;
+ eth->netdev[id]->min_mtu = ETH_MIN_MTU;
+ eth->netdev[id]->max_mtu = 1536;
+
return 0;
free_netdev:
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: ethernet: mtk_eth_soc: fix mtu warning
2020-07-08 15:46 [PATCH] net: ethernet: mtk_eth_soc: fix mtu warning Frank Wunderlich
@ 2020-07-08 16:32 ` Jakub Kicinski
2020-07-08 19:36 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-07-08 16:32 UTC (permalink / raw)
To: Frank Wunderlich
Cc: linux-mediatek, René van Dorst, Felix Fietkau, John Crispin,
Sean Wang, Mark Lee, David S. Miller, Matthias Brugger, netdev,
linux-arm-kernel, linux-kernel
On Wed, 8 Jul 2020 17:46:34 +0200 Frank Wunderlich wrote:
> From: René van Dorst <opensource@vdorst.com>
>
> in recent Kernel-Versions there are warnings about incorrect MTU-Size
> like these:
>
> mt7530 mdio-bus:00: nonfatal error -95 setting MTU on port x
> eth0: mtu greater than device maximum
> mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead
>
> Signed-off-by: René van Dorst <opensource@vdorst.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>
> Fixes: bfcb813203 ("net: dsa: configure the MTU for switch ports")
> Fixes: 72579e14a1 ("net: dsa: don't fail to probe if we couldn't set the MTU")
> Fixes: 7a4c53bee3 ("net: report invalid mtu value via netlink extack")
Fixes tag: Fixes: bfcb813203 ("net: dsa: configure the MTU for switch ports")
Has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
Fixes tag: Fixes: 72579e14a1 ("net: dsa: don't fail to probe if we couldn't set the MTU")
Has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
Fixes tag: Fixes: 7a4c53bee3 ("net: report invalid mtu value via netlink extack")
Has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: ethernet: mtk_eth_soc: fix mtu warning
2020-07-08 15:46 [PATCH] net: ethernet: mtk_eth_soc: fix mtu warning Frank Wunderlich
2020-07-08 16:32 ` Jakub Kicinski
@ 2020-07-08 19:36 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-07-08 19:36 UTC (permalink / raw)
To: frank-w
Cc: linux-mediatek, opensource, nbd, john, sean.wang, Mark-MC.Lee,
kuba, matthias.bgg, netdev, linux-arm-kernel, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
Date: Wed, 8 Jul 2020 17:46:34 +0200
> From: René van Dorst <opensource@vdorst.com>
>
> in recent Kernel-Versions there are warnings about incorrect MTU-Size
> like these:
>
> mt7530 mdio-bus:00: nonfatal error -95 setting MTU on port x
> eth0: mtu greater than device maximum
> mtk_soc_eth 1b100000.ethernet eth0: error -22 setting MTU to include DSA overhead
>
> Signed-off-by: René van Dorst <opensource@vdorst.com>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>
> Fixes: bfcb813203 ("net: dsa: configure the MTU for switch ports")
> Fixes: 72579e14a1 ("net: dsa: don't fail to probe if we couldn't set the MTU")
> Fixes: 7a4c53bee3 ("net: report invalid mtu value via netlink extack")
In addition to the other Fixes: tag problems pointed out so far, you should
always put the Fixes: tags first, and immediately before the other tags
such as Signed-off-by: etc. and with no empty lines separating them.
Thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-08 19:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-08 15:46 [PATCH] net: ethernet: mtk_eth_soc: fix mtu warning Frank Wunderlich
2020-07-08 16:32 ` Jakub Kicinski
2020-07-08 19:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®