* [PATCH -next] remoteproc: qcom: Add missing slab.h
@ 2020-07-13 2:00 Kefeng Wang
2020-07-13 18:55 ` Alex Elder
2020-07-13 19:01 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Kefeng Wang @ 2020-07-13 2:00 UTC (permalink / raw)
To: Rishabh Bhatnagar, Bjorn Andersson, linux-remoteproc, linux-kernel
Cc: Kefeng Wang, Hulk Robot
drivers/remoteproc/qcom_common.c: In function ‘qcom_ssr_get_subsys’:
drivers/remoteproc/qcom_common.c:210:9: error: implicit declaration of function ‘kzalloc’; did you mean ‘vzalloc’?
[-Werror=implicit-function-declaration]
info = kzalloc(sizeof(*info), GFP_KERNEL);
^~~~~~~
vzalloc
kzalloc() is declared in linux/slab.h, add include to fix build issue.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
drivers/remoteproc/qcom_common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c
index 2f45f0c79914e..085fd73fa23ae 100644
--- a/drivers/remoteproc/qcom_common.c
+++ b/drivers/remoteproc/qcom_common.c
@@ -15,6 +15,7 @@
#include <linux/remoteproc/qcom_rproc.h>
#include <linux/rpmsg/qcom_glink.h>
#include <linux/rpmsg/qcom_smd.h>
+#include <linux/slab.h>
#include <linux/soc/qcom/mdt_loader.h>
#include "remoteproc_internal.h"
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] remoteproc: qcom: Add missing slab.h
2020-07-13 2:00 [PATCH -next] remoteproc: qcom: Add missing slab.h Kefeng Wang
@ 2020-07-13 18:55 ` Alex Elder
2020-07-13 19:01 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Alex Elder @ 2020-07-13 18:55 UTC (permalink / raw)
To: Kefeng Wang, Rishabh Bhatnagar, Bjorn Andersson,
linux-remoteproc, linux-kernel
Cc: Hulk Robot
On 7/12/20 9:00 PM, Kefeng Wang wrote:
> drivers/remoteproc/qcom_common.c: In function ‘qcom_ssr_get_subsys’:
> drivers/remoteproc/qcom_common.c:210:9: error: implicit declaration of function ‘kzalloc’; did you mean ‘vzalloc’?
> [-Werror=implicit-function-declaration]
> info = kzalloc(sizeof(*info), GFP_KERNEL);
> ^~~~~~~
> vzalloc
>
> kzalloc() is declared in linux/slab.h, add include to fix build issue.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> drivers/remoteproc/qcom_common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c
> index 2f45f0c79914e..085fd73fa23ae 100644
> --- a/drivers/remoteproc/qcom_common.c
> +++ b/drivers/remoteproc/qcom_common.c
> @@ -15,6 +15,7 @@
> #include <linux/remoteproc/qcom_rproc.h>
> #include <linux/rpmsg/qcom_glink.h>
> #include <linux/rpmsg/qcom_smd.h>
> +#include <linux/slab.h>
> #include <linux/soc/qcom/mdt_loader.h>
>
> #include "remoteproc_internal.h"
You beat me to it. I just build-tested this fix on linux-next/master
and can confirm the build fails without it, succeeds with it.
-Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] remoteproc: qcom: Add missing slab.h
2020-07-13 2:00 [PATCH -next] remoteproc: qcom: Add missing slab.h Kefeng Wang
2020-07-13 18:55 ` Alex Elder
@ 2020-07-13 19:01 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2020-07-13 19:01 UTC (permalink / raw)
To: Kefeng Wang; +Cc: Rishabh Bhatnagar, linux-remoteproc, linux-kernel, Hulk Robot
On Sun 12 Jul 19:00 PDT 2020, Kefeng Wang wrote:
> drivers/remoteproc/qcom_common.c: In function ‘qcom_ssr_get_subsys’:
> drivers/remoteproc/qcom_common.c:210:9: error: implicit declaration of function ‘kzalloc’; did you mean ‘vzalloc’?
> [-Werror=implicit-function-declaration]
> info = kzalloc(sizeof(*info), GFP_KERNEL);
> ^~~~~~~
> vzalloc
>
> kzalloc() is declared in linux/slab.h, add include to fix build issue.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Thank Kefeng, patch applied.
Regards,
Bjorn
> ---
> drivers/remoteproc/qcom_common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c
> index 2f45f0c79914e..085fd73fa23ae 100644
> --- a/drivers/remoteproc/qcom_common.c
> +++ b/drivers/remoteproc/qcom_common.c
> @@ -15,6 +15,7 @@
> #include <linux/remoteproc/qcom_rproc.h>
> #include <linux/rpmsg/qcom_glink.h>
> #include <linux/rpmsg/qcom_smd.h>
> +#include <linux/slab.h>
> #include <linux/soc/qcom/mdt_loader.h>
>
> #include "remoteproc_internal.h"
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-13 19:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-13 2:00 [PATCH -next] remoteproc: qcom: Add missing slab.h Kefeng Wang
2020-07-13 18:55 ` Alex Elder
2020-07-13 19:01 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome