From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Scott Branden <scott.branden@broadcom.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Subject: Re: [PATCH v2] pwm: bcm-iproc: handle clk_get_rate() return
Date: Sat, 18 Jul 2020 01:04:31 +0200 [thread overview]
Message-ID: <20200717230431.4oj44cfnkhkd2o6z@pengutronix.de> (raw)
In-Reply-To: <20200717182512.26001-1-scott.branden@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
On Fri, Jul 17, 2020 at 11:25:12AM -0700, Scott Branden wrote:
> From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
>
> Handle clk_get_rate() returning <= 0 condition to avoid
> possible division by zero.
You advertise handling <= 0, but in the code only == 0 is checked. One
of the two is wrong ...
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-17 23:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 18:25 Scott Branden
2020-07-17 22:27 ` Ray Jui
2020-07-17 23:04 ` Uwe Kleine-König [this message]
2020-07-17 23:11 ` Scott Branden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717230431.4oj44cfnkhkd2o6z@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®