mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Evgeny Novikov <novikov@ispras.ru>
Cc: Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
	Corentin Labbe <clabbe@baylibre.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"ldv-project@linuxtesting.org" <ldv-project@linuxtesting.org>
Subject: Re: [PATCH] usb: gadget: net2280: fix memory leak on probe error handling paths
Date: Wed, 22 Jul 2020 21:00:55 -0400	[thread overview]
Message-ID: <20200723010055.GA1333715@rowland.harvard.edu> (raw)
In-Reply-To: <2097231595446720@mail.yandex.ru>

On Wed, Jul 22, 2020 at 10:56:09PM +0300, Evgeny Novikov wrote:
> Hi Alan,
> 
> I have neither an appropriate hardware nor an experience to deal with 
> issues that you mentioned. Our framework does not allow to detect them 
> as well at the moment. At last, it seems that rather many drivers can 
> suffer from these issues. So, it would be much better if somebody else 
> will suggest necessary fixes and test them carefully.

Heh...  Working from home, I no longer have access to the appropriate 
hardware either.  But at least I do have the necessary experience.  :-)

> BTW, you have already discussed the race within net2280_remove() with 
> my colleague about 3 years ago. But you did not achieve a consensus at 
> that time and no fixes were made after all.

I don't recall that.  Do you have a pointer to the email thread in the 
archives?

> Anyway, one can consider both issues independently on the one fixed by 
> the patch.

Yes.  I'll write and submit a series of patches.

Alan Stern

  parent reply	other threads:[~2020-07-23  1:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 20:15 Evgeny Novikov
2020-07-22 14:17 ` Alan Stern
2020-07-22 19:56   ` Evgeny Novikov
2020-07-23  0:59     ` Benjamin Herrenschmidt
2020-07-23  1:02       ` Alan Stern
2020-07-23  1:00     ` Alan Stern [this message]
2020-07-23  8:50       ` Evgeny Novikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200723010055.GA1333715@rowland.harvard.edu \
    --to=stern@rowland.harvard.edu \
    --cc=arnd@arndb.de \
    --cc=balbi@kernel.org \
    --cc=benh@kernel.crashing.org \
    --cc=clabbe@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=keescook@chromium.org \
    --cc=ldv-project@linuxtesting.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=novikov@ispras.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome