* [PATCH] net: cdc_ncm: USB_NET_CDC_NCM selects USB_NET_CDCETHER
@ 2020-07-23 14:22 trix
2020-07-25 2:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2020-07-23 14:22 UTC (permalink / raw)
To: davem, kuba, masahiroy; +Cc: linux-usb, netdev, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A link error
ld: drivers/net/usb/cdc_ncm.o:
undefined reference to `usbnet_cdc_update_filter'
usbnet_cdc_update_filter is defined in cdc_ether.c
Building of cdc_ether.o is controlled by USB_NET_CDCETHER
Building of cdc_ncm.o is controlled by USB_NET_CDC_NCM
So add a select USB_NET_CDCETHER to USB_NET_CDC_NCM
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/usb/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index a7fbc3ccd29e..c7bcfca7d70b 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -252,6 +252,7 @@ config USB_NET_CDC_EEM
config USB_NET_CDC_NCM
tristate "CDC NCM support"
depends on USB_USBNET
+ select USB_NET_CDCETHER
default y
help
This driver provides support for CDC NCM (Network Control Model
--
2.18.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: cdc_ncm: USB_NET_CDC_NCM selects USB_NET_CDCETHER
2020-07-23 14:22 [PATCH] net: cdc_ncm: USB_NET_CDC_NCM selects USB_NET_CDCETHER trix
@ 2020-07-25 2:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-07-25 2:54 UTC (permalink / raw)
To: trix; +Cc: kuba, masahiroy, linux-usb, netdev, linux-kernel
From: trix@redhat.com
Date: Thu, 23 Jul 2020 07:22:10 -0700
> From: Tom Rix <trix@redhat.com>
>
> A link error
>
> ld: drivers/net/usb/cdc_ncm.o:
> undefined reference to `usbnet_cdc_update_filter'
>
> usbnet_cdc_update_filter is defined in cdc_ether.c
> Building of cdc_ether.o is controlled by USB_NET_CDCETHER
>
> Building of cdc_ncm.o is controlled by USB_NET_CDC_NCM
>
> So add a select USB_NET_CDCETHER to USB_NET_CDC_NCM
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Please indicate the appropriate target tree ('net' or 'net-next') in
your Subject line f.e. "[PATCH net-next] ..."
Please provide an appropriate and properly formatted Fixes: tag.
Thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-25 2:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 14:22 [PATCH] net: cdc_ncm: USB_NET_CDC_NCM selects USB_NET_CDCETHER trix
2020-07-25 2:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome