* [PATCH 1/1] STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style Error
@ 2020-07-25 12:20 Anant Thazhemadam
2020-07-25 17:47 ` Larry Finger
0 siblings, 1 reply; 4+ messages in thread
From: Anant Thazhemadam @ 2020-07-25 12:20 UTC (permalink / raw)
Cc: anant.thazhemadam, Larry Finger, Greg Kroah-Hartman, Anoop S,
Michael Straube, Joe Perches, Merwin Trever Ferrao,
Rahul Gottipati, devel, linux-kernel
Running the checkpatch.pl script on the file for which patch was created, the
following error was found to exist.
ERROR: space required after that ',' (ctx:VxV)
Fixed the above error which was found on line #721 by inserting a blank
space at the appropriate position.
Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
index 21f6652dd69f..57e171d3e48d 100644
--- a/drivers/staging/rtl8188eu/core/rtw_security.c
+++ b/drivers/staging/rtl8188eu/core/rtw_security.c
@@ -718,7 +718,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
res = _FAIL;
}
} else {
- RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
+ RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n", __func__));
res = _FAIL;
}
}
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style Error
2020-07-25 12:20 [PATCH 1/1] STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style Error Anant Thazhemadam
@ 2020-07-25 17:47 ` Larry Finger
2020-07-25 18:39 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Larry Finger @ 2020-07-25 17:47 UTC (permalink / raw)
To: Anant Thazhemadam
Cc: Greg Kroah-Hartman, Anoop S, Michael Straube, Joe Perches,
Merwin Trever Ferrao, Rahul Gottipati, devel, linux-kernel
On 7/25/20 7:20 AM, Anant Thazhemadam wrote:
> Running the checkpatch.pl script on the file for which patch was created, the
> following error was found to exist.
> ERROR: space required after that ',' (ctx:VxV)
>
> Fixed the above error which was found on line #721 by inserting a blank
> space at the appropriate position.
>
> Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_security.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
> index 21f6652dd69f..57e171d3e48d 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_security.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_security.c
> @@ -718,7 +718,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
> res = _FAIL;
> }
> } else {
> - RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
> + RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n", __func__));
> res = _FAIL;
> }
> }
In fixing one checkpatch.pl condition, you introduced another - the resulting
line is too long. You should fix only one such condition, but you should fix any
others that are introduced. You do need to document it.
Patch subjects for this driver should be written as "staging: rtl8188eu: .....".
Larry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style Error
2020-07-25 17:47 ` Larry Finger
@ 2020-07-25 18:39 ` Joe Perches
2020-07-25 18:49 ` Larry Finger
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2020-07-25 18:39 UTC (permalink / raw)
To: Larry Finger, Anant Thazhemadam
Cc: Greg Kroah-Hartman, Anoop S, Michael Straube,
Merwin Trever Ferrao, Rahul Gottipati, devel, linux-kernel
On Sat, 2020-07-25 at 12:47 -0500, Larry Finger wrote:
> On 7/25/20 7:20 AM, Anant Thazhemadam wrote:
> > Running the checkpatch.pl script on the file for which patch was created, the
> > following error was found to exist.
> > ERROR: space required after that ',' (ctx:VxV)
> >
> > Fixed the above error which was found on line #721 by inserting a blank
> > space at the appropriate position.
[]
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
[]
> > @@ -718,7 +718,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
> > res = _FAIL;
> > }
> > } else {
> > - RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
> > + RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n", __func__));
> > res = _FAIL;
> > }
> > }
>
> In fixing one checkpatch.pl condition, you introduced another - the resulting
> line is too long. You should fix only one such condition, but you should fix any
> others that are introduced. You do need to document it.
I think that doesn't matter as it was also too long
before this change.
> Patch subjects for this driver should be written as "staging: rtl8188eu: .....".
How likely is it that this driver would ever be
moved to drivers/net/wireless/realtek/rtlwifi?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style Error
2020-07-25 18:39 ` Joe Perches
@ 2020-07-25 18:49 ` Larry Finger
0 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2020-07-25 18:49 UTC (permalink / raw)
To: Joe Perches, Anant Thazhemadam
Cc: Greg Kroah-Hartman, Anoop S, Michael Straube,
Merwin Trever Ferrao, Rahul Gottipati, devel, linux-kernel
On 7/25/20 1:39 PM, Joe Perches wrote:
> On Sat, 2020-07-25 at 12:47 -0500, Larry Finger wrote:
>> On 7/25/20 7:20 AM, Anant Thazhemadam wrote:
>>> Running the checkpatch.pl script on the file for which patch was created, the
>>> following error was found to exist.
>>> ERROR: space required after that ',' (ctx:VxV)
>>>
>>> Fixed the above error which was found on line #721 by inserting a blank
>>> space at the appropriate position.
> []
>>> diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
> []
>>> @@ -718,7 +718,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *precvframe)
>>> res = _FAIL;
>>> }
>>> } else {
>>> - RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n",__func__));
>>> + RT_TRACE(_module_rtl871x_security_c_, _drv_err_, ("%s: stainfo==NULL!!!\n", __func__));
>>> res = _FAIL;
>>> }
>>> }
>>
>> In fixing one checkpatch.pl condition, you introduced another - the resulting
>> line is too long. You should fix only one such condition, but you should fix any
>> others that are introduced. You do need to document it.
>
> I think that doesn't matter as it was also too long
> before this change.
>
>> Patch subjects for this driver should be written as "staging: rtl8188eu: .....".
>
> How likely is it that this driver would ever be
> moved to drivers/net/wireless/realtek/rtlwifi?
Very unlikely. It I wanted to undertake that kind of effort, I would switch to
one of the later versions from Realtek that uses nl80211/cfg80211. Despite that,
it is likely that only the USB driver from rtlwifi could be used.
Larry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-25 18:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-25 12:20 [PATCH 1/1] STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style Error Anant Thazhemadam
2020-07-25 17:47 ` Larry Finger
2020-07-25 18:39 ` Joe Perches
2020-07-25 18:49 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®