* [PATCH] x86/acrn: Allow ACRN guest to use X2APIC mode
@ 2020-08-06 11:38 Shuo Liu
2020-08-06 17:10 ` [tip: x86/urgent] " tip-bot2 for Shuo Liu
2020-08-06 23:38 ` tip-bot2 for Shuo Liu
0 siblings, 2 replies; 3+ messages in thread
From: Shuo Liu @ 2020-08-06 11:38 UTC (permalink / raw)
To: x86, linux-kernel
Cc: H . Peter Anvin, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
Dave Hansen, Sean Christopherson, Dan Williams, Yu Wang,
Reinette Chatre, Fengwei Yin, Zhi Wang, Zhenyu Wang
The ACRN Hypervisor did not support x2APIC and thus x2APIC support was
disabled by always returning false when VM checked for x2APIC support.
ACRN received full support of x2APIC and exports the capability through
CPUID feature bits.
Let VM decide if it needs to switch to x2APIC mode according to CPUID
features.
Originally-by: Yakui Zhao <yakui.zhao@intel.com>
Signed-off-by: Shuo Liu <shuo.a.liu@intel.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Fengwei Yin <fengwei.yin@intel.com>
Cc: Zhi Wang <zhi.a.wang@intel.com>
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: Yu Wang <yu1.wang@intel.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>
---
arch/x86/kernel/cpu/acrn.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c
index 1da9b1c9a2db..3b08cdfc6514 100644
--- a/arch/x86/kernel/cpu/acrn.c
+++ b/arch/x86/kernel/cpu/acrn.c
@@ -11,6 +11,7 @@
#include <linux/interrupt.h>
#include <asm/apic.h>
+#include <asm/cpufeatures.h>
#include <asm/desc.h>
#include <asm/hypervisor.h>
#include <asm/idtentry.h>
@@ -29,12 +30,7 @@ static void __init acrn_init_platform(void)
static bool acrn_x2apic_available(void)
{
- /*
- * x2apic is not supported for now. Future enablement will have to check
- * X86_FEATURE_X2APIC to determine whether x2apic is supported in the
- * guest.
- */
- return false;
+ return boot_cpu_has(X86_FEATURE_X2APIC);
}
static void (*acrn_intr_handler)(void);
base-commit: 48778464bb7d346b47157d21ffde2af6b2d39110
--
2.28.0
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip: x86/urgent] x86/acrn: Allow ACRN guest to use X2APIC mode
2020-08-06 11:38 [PATCH] x86/acrn: Allow ACRN guest to use X2APIC mode Shuo Liu
@ 2020-08-06 17:10 ` tip-bot2 for Shuo Liu
2020-08-06 23:38 ` tip-bot2 for Shuo Liu
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Shuo Liu @ 2020-08-06 17:10 UTC (permalink / raw)
To: linux-tip-commits
Cc: Yakui Zhao, Shuo Liu, Ingo Molnar, Reinette Chatre, x86, LKML
The following commit has been merged into the x86/urgent branch of tip:
Commit-ID: f75576c4818fdf344691ca5b791f42bf3878c3a8
Gitweb: https://git.kernel.org/tip/f75576c4818fdf344691ca5b791f42bf3878c3a8
Author: Shuo Liu <shuo.a.liu@intel.com>
AuthorDate: Thu, 06 Aug 2020 19:38:02 +08:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Thu, 06 Aug 2020 15:20:17 +02:00
x86/acrn: Allow ACRN guest to use X2APIC mode
The ACRN Hypervisor did not support x2APIC and thus x2APIC support was
disabled by always returning false when VM checked for x2APIC support.
ACRN received full support of x2APIC and exports the capability through
CPUID feature bits.
Let VM decide if it needs to switch to x2APIC mode according to CPUID
features.
Originally-by: Yakui Zhao <yakui.zhao@intel.com>
Signed-off-by: Shuo Liu <shuo.a.liu@intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Link: https://lore.kernel.org/r/20200806113802.9325-1-shuo.a.liu@intel.com
---
arch/x86/kernel/cpu/acrn.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c
index 1da9b1c..3b08cdf 100644
--- a/arch/x86/kernel/cpu/acrn.c
+++ b/arch/x86/kernel/cpu/acrn.c
@@ -11,6 +11,7 @@
#include <linux/interrupt.h>
#include <asm/apic.h>
+#include <asm/cpufeatures.h>
#include <asm/desc.h>
#include <asm/hypervisor.h>
#include <asm/idtentry.h>
@@ -29,12 +30,7 @@ static void __init acrn_init_platform(void)
static bool acrn_x2apic_available(void)
{
- /*
- * x2apic is not supported for now. Future enablement will have to check
- * X86_FEATURE_X2APIC to determine whether x2apic is supported in the
- * guest.
- */
- return false;
+ return boot_cpu_has(X86_FEATURE_X2APIC);
}
static void (*acrn_intr_handler)(void);
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip: x86/urgent] x86/acrn: Allow ACRN guest to use X2APIC mode
2020-08-06 11:38 [PATCH] x86/acrn: Allow ACRN guest to use X2APIC mode Shuo Liu
2020-08-06 17:10 ` [tip: x86/urgent] " tip-bot2 for Shuo Liu
@ 2020-08-06 23:38 ` tip-bot2 for Shuo Liu
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Shuo Liu @ 2020-08-06 23:38 UTC (permalink / raw)
To: linux-tip-commits
Cc: Yakui Zhao, Shuo Liu, Ingo Molnar, Reinette Chatre, x86, LKML
The following commit has been merged into the x86/urgent branch of tip:
Commit-ID: 86d709ce30eaa65706090865662a08d7bdd30c54
Gitweb: https://git.kernel.org/tip/86d709ce30eaa65706090865662a08d7bdd30c54
Author: Shuo Liu <shuo.a.liu@intel.com>
AuthorDate: Thu, 06 Aug 2020 19:38:02 +08:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Fri, 07 Aug 2020 01:32:00 +02:00
x86/acrn: Allow ACRN guest to use X2APIC mode
The ACRN Hypervisor did not support x2APIC and thus x2APIC support was
disabled by always returning false when VM checked for x2APIC support.
ACRN received full support of x2APIC and exports the capability through
CPUID feature bits.
Let VM decide if it needs to switch to x2APIC mode according to CPUID
features.
Originally-by: Yakui Zhao <yakui.zhao@intel.com>
Signed-off-by: Shuo Liu <shuo.a.liu@intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Link: https://lore.kernel.org/r/20200806113802.9325-1-shuo.a.liu@intel.com
---
arch/x86/kernel/cpu/acrn.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c
index 1da9b1c..3b08cdf 100644
--- a/arch/x86/kernel/cpu/acrn.c
+++ b/arch/x86/kernel/cpu/acrn.c
@@ -11,6 +11,7 @@
#include <linux/interrupt.h>
#include <asm/apic.h>
+#include <asm/cpufeatures.h>
#include <asm/desc.h>
#include <asm/hypervisor.h>
#include <asm/idtentry.h>
@@ -29,12 +30,7 @@ static void __init acrn_init_platform(void)
static bool acrn_x2apic_available(void)
{
- /*
- * x2apic is not supported for now. Future enablement will have to check
- * X86_FEATURE_X2APIC to determine whether x2apic is supported in the
- * guest.
- */
- return false;
+ return boot_cpu_has(X86_FEATURE_X2APIC);
}
static void (*acrn_intr_handler)(void);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-06 23:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-06 11:38 [PATCH] x86/acrn: Allow ACRN guest to use X2APIC mode Shuo Liu
2020-08-06 17:10 ` [tip: x86/urgent] " tip-bot2 for Shuo Liu
2020-08-06 23:38 ` tip-bot2 for Shuo Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®