From: Mark Brown <broonie@kernel.org>
To: Alain Volmat <alain.volmat@st.com>
Cc: amelie.delaunay@st.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, linux-spi@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, fabrice.gasnier@st.com
Subject: Re: [PATCH 2/5] spi: stm32: fix fifo threshold level in case of short transfer
Date: Fri, 7 Aug 2020 14:27:22 +0100 [thread overview]
Message-ID: <20200807132722.GJ5435@sirena.org.uk> (raw)
In-Reply-To: <1596806485-3810-3-git-send-email-alain.volmat@st.com>
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
On Fri, Aug 07, 2020 at 03:21:22PM +0200, Alain Volmat wrote:
> + /* data_packet should not exceed transfer length */
> + packet = (half_fifo > xfer_len) ? xfer_len : half_fifo;
Please write normal conditional statements to improve legibility.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-08-07 13:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 13:21 [PATCH 0/5] spi: stm32: various driver fixes Alain Volmat
2020-08-07 13:21 ` [PATCH 1/5] spi: stm32h7: fix race condition at end of transfer Alain Volmat
2020-08-07 13:21 ` [PATCH 2/5] spi: stm32: fix fifo threshold level in case of short transfer Alain Volmat
2020-08-07 13:27 ` Mark Brown [this message]
2020-08-07 13:21 ` [PATCH 3/5] spi: stm32: fix stm32_spi_prepare_mbr in case of odd clk_rate Alain Volmat
2020-08-07 13:21 ` [PATCH 4/5] spi: stm32: fixes suspend/resume management Alain Volmat
2020-08-07 13:21 ` [PATCH 5/5] spi: stm32: always perform registers configuration prior to transfer Alain Volmat
2020-08-10 18:58 ` [PATCH 0/5] spi: stm32: various driver fixes Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807132722.GJ5435@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alain.volmat@st.com \
--cc=alexandre.torgue@st.com \
--cc=amelie.delaunay@st.com \
--cc=fabrice.gasnier@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®