From: Jim Cromie <jim.cromie@gmail.com>
To: jbaron@akamai.com, linux-kernel@vger.kernel.org
Cc: Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 6/8] dyndbg: ddebug_zpool_remove
Date: Fri, 7 Aug 2020 14:09:54 -0600 [thread overview]
Message-ID: <20200807200957.1269454-8-jim.cromie@gmail.com> (raw)
In-Reply-To: <20200807200957.1269454-1-jim.cromie@gmail.com>
add ddebug_zpool_remove() to undo ddebug_zpool_add(), and call it from
ddebug_remove_module().
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
lib/dynamic_debug.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 049299027fb3..102f47b2a439 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1007,6 +1007,18 @@ static void ddebug_zpool_add(struct _ddebug *dp)
zs_unmap_object(dd_callsite_zpool, handle);
}
+static void ddebug_zpool_remove(struct _ddebug *dp)
+{
+ if (dp->site) {
+ pr_warn("zhandle shouldnt be mapped now\n");
+ zs_unmap_object(dd_callsite_zpool, dp->zhandle);
+ }
+ if (!dp->zhandle)
+ pr_err("zhandle already cleared !\n");
+ else
+ zs_free(dd_callsite_zpool, dp->zhandle);
+}
+
/*
* Allocate a new ddebug_table for the given module
* and add it to the global list.
@@ -1104,6 +1116,13 @@ int ddebug_remove_module(const char *mod_name)
mutex_lock(&ddebug_lock);
list_for_each_entry_safe(dt, nextdt, &ddebug_tables, link) {
if (dt->mod_name == mod_name) {
+
+ unsigned int n = dt->num_ddebugs;
+ struct _ddebug *dp = dt->ddebugs;
+
+ for (; n; n--, dp++)
+ ddebug_zpool_remove(dp);
+
ddebug_table_free(dt);
ret = 0;
break;
--
2.26.2
next prev parent reply other threads:[~2020-08-07 20:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 20:09 [PATCH 0/7] dyndbg: WIP diet plan Jim Cromie
2020-08-07 20:09 ` [PATCH 1/7] dyndbg: give %3u width in pr-format, cosmetic only Jim Cromie
2020-08-07 20:09 ` [PATCH 2/7] dyndbg: motivate a diet plan Jim Cromie
2020-08-07 20:09 ` [PATCH 3/7] dyndbg: select ZPOOL in Kconfig.debug Jim Cromie
2020-08-09 5:05 ` Randy Dunlap
2020-08-09 15:09 ` jim.cromie
2020-08-07 20:09 ` [PATCH 4/7] dyndbg: split struct _ddebug in 2, creating _ddebug_callsite Jim Cromie
2020-08-07 20:09 ` [PATCH 5/7] dyndbg: WIP replace __dyndbg_callsite section with a zs-pool copy Jim Cromie
2020-08-07 23:50 ` kernel test robot
2020-08-07 20:09 ` [PATCH 6/7] dyndbg: add locking around zpool-add loop in zpool-init Jim Cromie
2020-08-07 20:09 ` Jim Cromie [this message]
2020-08-07 20:09 ` [PATCH 7/7] dyndbg: enable 'cache' of active pr_debug callsites Jim Cromie
2020-08-09 4:35 ` [dyndbg] 4397a3e7bf: BUG:sleeping_function_called_from_invalid_context_at_mm/slab.h kernel test robot
2020-08-12 15:11 ` jim.cromie
2020-08-07 20:09 ` [PATCH 8/8] dyndbg: add locking around zpool-add loop in zpool-init Jim Cromie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807200957.1269454-8-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®