* [PATCH] drm/amd/display: remove unintended executable mode
@ 2020-08-19 8:18 Lukas Bulwahn
2020-08-19 8:53 ` Christian König
2020-08-21 0:42 ` Li, Dennis
0 siblings, 2 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2020-08-19 8:18 UTC (permalink / raw)
To: Alex Deucher, Christian König, Dennis Li, Jerry Zuo
Cc: amd-gfx, dri-devel, linux-kernel, Guchun Chen, Hersen Wu, Lukas Bulwahn
Besides the intended change, commit 4cc1178e166a ("drm/amdgpu: replace DRM
prefix with PCI device info for gfx/mmhub") also set the source files
mmhub_v1_0.c and gfx_v9_4.c to be executable, i.e., changed fromold mode
644 to new mode 755.
Commit 241b2ec9317e ("drm/amd/display: Add dcn30 Headers (v2)") added the
four header files {dpcs,dcn}_3_0_0_{offset,sh_mask}.h as executable, i.e.,
mode 755.
Set to the usual modes for source and headers files and clean up those
mistakes. No functional change.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
applies cleanly on current master and next-20200819
Alex, Christian, please pick this minor non-urgent cleanup patch.
Dennis, Jerry, please ack.
Dennis, Jerry, you might want to check your development environment
introducing those executable modes on files.
drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c | 0
drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 0
drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h | 0
drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h | 0
drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h | 0
drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h | 0
6 files changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c
mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h
mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h
mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h
mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c
old mode 100755
new mode 100644
diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
old mode 100755
new mode 100644
diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h
old mode 100755
new mode 100644
diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h
old mode 100755
new mode 100644
diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h
old mode 100755
new mode 100644
diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h
old mode 100755
new mode 100644
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amd/display: remove unintended executable mode 2020-08-19 8:18 [PATCH] drm/amd/display: remove unintended executable mode Lukas Bulwahn @ 2020-08-19 8:53 ` Christian König 2020-08-20 18:03 ` Alex Deucher 2020-08-21 0:42 ` Li, Dennis 1 sibling, 1 reply; 4+ messages in thread From: Christian König @ 2020-08-19 8:53 UTC (permalink / raw) To: Lukas Bulwahn, Alex Deucher, Dennis Li, Jerry Zuo Cc: amd-gfx, dri-devel, linux-kernel, Guchun Chen, Hersen Wu Am 19.08.20 um 10:18 schrieb Lukas Bulwahn: > Besides the intended change, commit 4cc1178e166a ("drm/amdgpu: replace DRM > prefix with PCI device info for gfx/mmhub") also set the source files > mmhub_v1_0.c and gfx_v9_4.c to be executable, i.e., changed fromold mode > 644 to new mode 755. > > Commit 241b2ec9317e ("drm/amd/display: Add dcn30 Headers (v2)") added the > four header files {dpcs,dcn}_3_0_0_{offset,sh_mask}.h as executable, i.e., > mode 755. > > Set to the usual modes for source and headers files and clean up those > mistakes. No functional change. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> Reviewed-by: Christian König <christian.koenig@amd.com> > --- > applies cleanly on current master and next-20200819 > > Alex, Christian, please pick this minor non-urgent cleanup patch. Alex is usually the one picking those up. If he misses something feel free to ping us once more. Thanks, Christian. > > Dennis, Jerry, please ack. > > Dennis, Jerry, you might want to check your development environment > introducing those executable modes on files. > > drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c | 0 > drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 0 > drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h | 0 > drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h | 0 > drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h | 0 > drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h | 0 > 6 files changed, 0 insertions(+), 0 deletions(-) > mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c > mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c > mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h > mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h > mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h > mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c > old mode 100755 > new mode 100644 > diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c > old mode 100755 > new mode 100644 > diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h > old mode 100755 > new mode 100644 > diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h > old mode 100755 > new mode 100644 > diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h > old mode 100755 > new mode 100644 > diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h > old mode 100755 > new mode 100644 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/display: remove unintended executable mode 2020-08-19 8:53 ` Christian König @ 2020-08-20 18:03 ` Alex Deucher 0 siblings, 0 replies; 4+ messages in thread From: Alex Deucher @ 2020-08-20 18:03 UTC (permalink / raw) To: Christian König Cc: Lukas Bulwahn, Alex Deucher, Dennis Li, Jerry Zuo, Guchun Chen, Hersen Wu, Maling list - DRI developers, amd-gfx list, LKML Applied. Thanks! Alex On Wed, Aug 19, 2020 at 4:53 AM Christian König <christian.koenig@amd.com> wrote: > > Am 19.08.20 um 10:18 schrieb Lukas Bulwahn: > > Besides the intended change, commit 4cc1178e166a ("drm/amdgpu: replace DRM > > prefix with PCI device info for gfx/mmhub") also set the source files > > mmhub_v1_0.c and gfx_v9_4.c to be executable, i.e., changed fromold mode > > 644 to new mode 755. > > > > Commit 241b2ec9317e ("drm/amd/display: Add dcn30 Headers (v2)") added the > > four header files {dpcs,dcn}_3_0_0_{offset,sh_mask}.h as executable, i.e., > > mode 755. > > > > Set to the usual modes for source and headers files and clean up those > > mistakes. No functional change. > > > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > > Reviewed-by: Christian König <christian.koenig@amd.com> > > > --- > > applies cleanly on current master and next-20200819 > > > > Alex, Christian, please pick this minor non-urgent cleanup patch. > > Alex is usually the one picking those up. If he misses something feel > free to ping us once more. > > Thanks, > Christian. > > > > > Dennis, Jerry, please ack. > > > > Dennis, Jerry, you might want to check your development environment > > introducing those executable modes on files. > > > > drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c | 0 > > drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 0 > > drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h | 0 > > drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h | 0 > > drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h | 0 > > drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h | 0 > > 6 files changed, 0 insertions(+), 0 deletions(-) > > mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c > > mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c > > mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h > > mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h > > mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h > > mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c > > old mode 100755 > > new mode 100644 > > diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c > > old mode 100755 > > new mode 100644 > > diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h > > old mode 100755 > > new mode 100644 > > diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h > > old mode 100755 > > new mode 100644 > > diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h > > old mode 100755 > > new mode 100644 > > diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h > > old mode 100755 > > new mode 100644 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amd/display: remove unintended executable mode 2020-08-19 8:18 [PATCH] drm/amd/display: remove unintended executable mode Lukas Bulwahn 2020-08-19 8:53 ` Christian König @ 2020-08-21 0:42 ` Li, Dennis 1 sibling, 0 replies; 4+ messages in thread From: Li, Dennis @ 2020-08-21 0:42 UTC (permalink / raw) To: Lukas Bulwahn, Deucher, Alexander, Koenig, Christian, Zuo, Jerry Cc: amd-gfx, dri-devel, linux-kernel, Chen, Guchun, Wu, Hersen [AMD Official Use Only - Internal Distribution Only] Hi, Lukas, Thanks for your fix. This issue was caused by that I modified these files in windows system with Samba. I will take care in the future. Best Regards Dennis Li -----Original Message----- From: Lukas Bulwahn <lukas.bulwahn@gmail.com> Sent: Wednesday, August 19, 2020 4:18 PM To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Li, Dennis <Dennis.Li@amd.com>; Zuo, Jerry <Jerry.Zuo@amd.com> Cc: amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Chen, Guchun <Guchun.Chen@amd.com>; Wu, Hersen <hersenxs.wu@amd.com>; Lukas Bulwahn <lukas.bulwahn@gmail.com> Subject: [PATCH] drm/amd/display: remove unintended executable mode Besides the intended change, commit 4cc1178e166a ("drm/amdgpu: replace DRM prefix with PCI device info for gfx/mmhub") also set the source files mmhub_v1_0.c and gfx_v9_4.c to be executable, i.e., changed fromold mode 644 to new mode 755. Commit 241b2ec9317e ("drm/amd/display: Add dcn30 Headers (v2)") added the four header files {dpcs,dcn}_3_0_0_{offset,sh_mask}.h as executable, i.e., mode 755. Set to the usual modes for source and headers files and clean up those mistakes. No functional change. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- applies cleanly on current master and next-20200819 Alex, Christian, please pick this minor non-urgent cleanup patch. Dennis, Jerry, please ack. Dennis, Jerry, you might want to check your development environment introducing those executable modes on files. drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c | 0 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h | 0 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h | 0 6 files changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c mode change 100755 => 100644 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h mode change 100755 => 100644 drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c old mode 100755 new mode 100644 diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c old mode 100755 new mode 100644 diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_offset.h old mode 100755 new mode 100644 diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dcn_3_0_0_sh_mask.h old mode 100755 new mode 100644 diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_offset.h old mode 100755 new mode 100644 diff --git a/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h b/drivers/gpu/drm/amd/include/asic_reg/dcn/dpcs_3_0_0_sh_mask.h old mode 100755 new mode 100644 -- 2.17.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-21 0:42 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-08-19 8:18 [PATCH] drm/amd/display: remove unintended executable mode Lukas Bulwahn 2020-08-19 8:53 ` Christian König 2020-08-20 18:03 ` Alex Deucher 2020-08-21 0:42 ` Li, Dennis
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome