* [PATCH] scsi: ufs-mediatek: Modify the minimum RX/TX lane count to 2
@ 2020-08-19 8:43 Stanley Chu
2020-08-20 6:03 ` Avri Altman
2020-09-09 2:17 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Stanley Chu @ 2020-08-19 8:43 UTC (permalink / raw)
To: linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb
Cc: matthias.bgg, bvanassche, linux-mediatek, linux-arm-kernel,
linux-kernel, kuohong.wang, peter.wang, chun-hung.wu, andy.teng,
chaotian.jing, cc.chou, Stanley Chu
From: Andy Teng <andy.teng@mediatek.com>
MediaTek UFS host starts to support 2 lanes, thus modify the
minimum lane count to 2.
This modification shall not impact old 1-lane host because
PA_CONNECTEDRXDATALANES and PA_CONNECTEDTXDATALANES will limit the
target lanes properly during power mode change. So we could relax
the limitation in ufs_dev_params.
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Signed-off-by: Andy Teng <andy.teng@mediatek.com>
Singed-off-by: Stanley Chu <stanley.chu@mediatek.com>
---
drivers/scsi/ufs/ufs-mediatek.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-mediatek.h b/drivers/scsi/ufs/ufs-mediatek.h
index 8ed24d5fcff9..87657376d27a 100644
--- a/drivers/scsi/ufs/ufs-mediatek.h
+++ b/drivers/scsi/ufs/ufs-mediatek.h
@@ -33,8 +33,8 @@
/*
* Vendor specific pre-defined parameters
*/
-#define UFS_MTK_LIMIT_NUM_LANES_RX 1
-#define UFS_MTK_LIMIT_NUM_LANES_TX 1
+#define UFS_MTK_LIMIT_NUM_LANES_RX 2
+#define UFS_MTK_LIMIT_NUM_LANES_TX 2
#define UFS_MTK_LIMIT_HSGEAR_RX UFS_HS_G3
#define UFS_MTK_LIMIT_HSGEAR_TX UFS_HS_G3
#define UFS_MTK_LIMIT_PWMGEAR_RX UFS_PWM_G4
--
2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] scsi: ufs-mediatek: Modify the minimum RX/TX lane count to 2
2020-08-19 8:43 [PATCH] scsi: ufs-mediatek: Modify the minimum RX/TX lane count to 2 Stanley Chu
@ 2020-08-20 6:03 ` Avri Altman
2020-09-09 2:17 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Avri Altman @ 2020-08-20 6:03 UTC (permalink / raw)
To: Stanley Chu, linux-scsi, martin.petersen, alim.akhtar, jejb
Cc: matthias.bgg, bvanassche, linux-mediatek, linux-arm-kernel,
linux-kernel, kuohong.wang, peter.wang, chun-hung.wu, andy.teng,
chaotian.jing, cc.chou
>
> From: Andy Teng <andy.teng@mediatek.com>
>
> MediaTek UFS host starts to support 2 lanes, thus modify the
> minimum lane count to 2.
>
> This modification shall not impact old 1-lane host because
> PA_CONNECTEDRXDATALANES and PA_CONNECTEDTXDATALANES will limit
> the
> target lanes properly during power mode change. So we could relax
> the limitation in ufs_dev_params.
>
> Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
> Signed-off-by: Andy Teng <andy.teng@mediatek.com>
> Singed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
But then again, why those constants needs to be re-negotiated every pre-change?
Thanks,
Avri
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: ufs-mediatek: Modify the minimum RX/TX lane count to 2
2020-08-19 8:43 [PATCH] scsi: ufs-mediatek: Modify the minimum RX/TX lane count to 2 Stanley Chu
2020-08-20 6:03 ` Avri Altman
@ 2020-09-09 2:17 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-09-09 2:17 UTC (permalink / raw)
To: alim.akhtar, jejb, Stanley Chu, linux-scsi, avri.altman
Cc: Martin K . Petersen, chaotian.jing, kuohong.wang, bvanassche,
chun-hung.wu, cc.chou, peter.wang, andy.teng, linux-kernel,
linux-mediatek, matthias.bgg, linux-arm-kernel
On Wed, 19 Aug 2020 16:43:40 +0800, Stanley Chu wrote:
> MediaTek UFS host starts to support 2 lanes, thus modify the
> minimum lane count to 2.
>
> This modification shall not impact old 1-lane host because
> PA_CONNECTEDRXDATALANES and PA_CONNECTEDTXDATALANES will limit the
> target lanes properly during power mode change. So we could relax
> the limitation in ufs_dev_params.
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: ufs: ufs-mediatek: Modify the minimum RX/TX lane count to 2
https://git.kernel.org/mkp/scsi/c/460d74a0911c
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-09 2:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19 8:43 [PATCH] scsi: ufs-mediatek: Modify the minimum RX/TX lane count to 2 Stanley Chu
2020-08-20 6:03 ` Avri Altman
2020-09-09 2:17 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome