mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH -next] ext2: remove duplicate include
@ 2020-08-19  2:54 Wang Hai
  2020-08-19  5:00 ` Ritesh Harjani
  0 siblings, 1 reply; 3+ messages in thread
From: Wang Hai @ 2020-08-19  2:54 UTC (permalink / raw)
  To: jack; +Cc: linux-ext4, linux-kernel

Remove linux/fiemap.h which is included more than once

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
 fs/ext2/inode.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index 80662e1f7889..de6b97612410 100644
--- a/fs/ext2/inode.c
+++ b/fs/ext2/inode.c
@@ -36,7 +36,6 @@
 #include <linux/iomap.h>
 #include <linux/namei.h>
 #include <linux/uio.h>
-#include <linux/fiemap.h>
 #include "ext2.h"
 #include "acl.h"
 #include "xattr.h"
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] ext2: remove duplicate include
  2020-08-19  2:54 [PATCH -next] ext2: remove duplicate include Wang Hai
@ 2020-08-19  5:00 ` Ritesh Harjani
  2020-08-19  9:01   ` Jan Kara
  0 siblings, 1 reply; 3+ messages in thread
From: Ritesh Harjani @ 2020-08-19  5:00 UTC (permalink / raw)
  To: Wang Hai, jack; +Cc: linux-ext4, linux-kernel



On 8/19/20 8:24 AM, Wang Hai wrote:
> Remove linux/fiemap.h which is included more than once
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>


LGTM, please feel free to add,
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>

> ---
>   fs/ext2/inode.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index 80662e1f7889..de6b97612410 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -36,7 +36,6 @@
>   #include <linux/iomap.h>
>   #include <linux/namei.h>
>   #include <linux/uio.h>
> -#include <linux/fiemap.h>
>   #include "ext2.h"
>   #include "acl.h"
>   #include "xattr.h"
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] ext2: remove duplicate include
  2020-08-19  5:00 ` Ritesh Harjani
@ 2020-08-19  9:01   ` Jan Kara
  0 siblings, 0 replies; 3+ messages in thread
From: Jan Kara @ 2020-08-19  9:01 UTC (permalink / raw)
  To: Ritesh Harjani; +Cc: Wang Hai, jack, linux-ext4, linux-kernel

On Wed 19-08-20 10:30:49, Ritesh Harjani wrote:
> 
> 
> On 8/19/20 8:24 AM, Wang Hai wrote:
> > Remove linux/fiemap.h which is included more than once
> > 
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Wang Hai <wanghai38@huawei.com>
> 
> 
> LGTM, please feel free to add,
> Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>

Thanks. I've added the patch to my tree.

								Honza

> 
> > ---
> >   fs/ext2/inode.c | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> > index 80662e1f7889..de6b97612410 100644
> > --- a/fs/ext2/inode.c
> > +++ b/fs/ext2/inode.c
> > @@ -36,7 +36,6 @@
> >   #include <linux/iomap.h>
> >   #include <linux/namei.h>
> >   #include <linux/uio.h>
> > -#include <linux/fiemap.h>
> >   #include "ext2.h"
> >   #include "acl.h"
> >   #include "xattr.h"
> > 
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-19  9:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19  2:54 [PATCH -next] ext2: remove duplicate include Wang Hai
2020-08-19  5:00 ` Ritesh Harjani
2020-08-19  9:01   ` Jan Kara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®