* [PATCH V2] ARM: dts: imx6q-logicpd: Fix broken PWM
@ 2020-08-19 19:48 Adam Ford
2020-08-19 19:54 ` Fabio Estevam
0 siblings, 1 reply; 2+ messages in thread
From: Adam Ford @ 2020-08-19 19:48 UTC (permalink / raw)
To: linux-arm-kernel
Cc: aford, Adam Ford, Rob Herring, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Uwe Kleine-König, devicetree, linux-kernel
The DTC doesn't like the default PWM settings, because it's expecting
three cells. This patch reduces adds the extra entry of 0 to the PWM
reference.
Fixes: fa28d8212ede ("ARM: dts: imx: default to #pwm-cells = <3> in the SoC dtsi files")
---
V2: Don't change HDMI
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/arch/arm/boot/dts/imx6q-logicpd.dts b/arch/arm/boot/dts/imx6q-logicpd.dts
index 7a3d1d3e54a9..8f94364ba484 100644
--- a/arch/arm/boot/dts/imx6q-logicpd.dts
+++ b/arch/arm/boot/dts/imx6q-logicpd.dts
@@ -13,7 +13,7 @@ / {
backlight: backlight-lvds {
compatible = "pwm-backlight";
- pwms = <&pwm3 0 20000>;
+ pwms = <&pwm3 0 20000 0>;
brightness-levels = <0 4 8 16 32 64 128 255>;
default-brightness-level = <6>;
power-supply = <®_lcd>;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH V2] ARM: dts: imx6q-logicpd: Fix broken PWM
2020-08-19 19:48 [PATCH V2] ARM: dts: imx6q-logicpd: Fix broken PWM Adam Ford
@ 2020-08-19 19:54 ` Fabio Estevam
0 siblings, 0 replies; 2+ messages in thread
From: Fabio Estevam @ 2020-08-19 19:54 UTC (permalink / raw)
To: Adam Ford
Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Adam Ford-BE, Rob Herring, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, NXP Linux Team, Uwe Kleine-König,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel
Hi Adam,
On Wed, Aug 19, 2020 at 4:48 PM Adam Ford <aford173@gmail.com> wrote:
>
> The DTC doesn't like the default PWM settings, because it's expecting
> three cells. This patch reduces adds the extra entry of 0 to the PWM
> reference.
>
> Fixes: fa28d8212ede ("ARM: dts: imx: default to #pwm-cells = <3> in the SoC dtsi files")
> ---
> V2: Don't change HDMI
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
Your Signed-off-by tag should go below the Fixes line (without a blank
line between) and above the --- line.
With that fixed you can add:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-19 19:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19 19:48 [PATCH V2] ARM: dts: imx6q-logicpd: Fix broken PWM Adam Ford
2020-08-19 19:54 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®