* [PATCH] irqchip/eznps: Fix build error for !ARC700 builds
@ 2020-08-24 23:01 Vineet Gupta
2020-08-25 7:21 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 4+ messages in thread
From: Vineet Gupta @ 2020-08-24 23:01 UTC (permalink / raw)
To: linux-snps-arc
Cc: linux-kernel, oferle, Vineet Gupta, kernel test robot,
Sebastian Andrzej Siewior
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: http://lists.infradead.org/pipermail/linux-snps-arc/2020-August/004032.html
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
arch/arc/plat-eznps/include/plat/ctop.h | 1 -
include/soc/nps/common.h | 6 ++++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arc/plat-eznps/include/plat/ctop.h b/arch/arc/plat-eznps/include/plat/ctop.h
index a4a61531c7fb..77712c5ffe84 100644
--- a/arch/arc/plat-eznps/include/plat/ctop.h
+++ b/arch/arc/plat-eznps/include/plat/ctop.h
@@ -33,7 +33,6 @@
#define CTOP_AUX_DPC (CTOP_AUX_BASE + 0x02C)
#define CTOP_AUX_LPC (CTOP_AUX_BASE + 0x030)
#define CTOP_AUX_EFLAGS (CTOP_AUX_BASE + 0x080)
-#define CTOP_AUX_IACK (CTOP_AUX_BASE + 0x088)
#define CTOP_AUX_GPA1 (CTOP_AUX_BASE + 0x08C)
#define CTOP_AUX_UDMC (CTOP_AUX_BASE + 0x300)
diff --git a/include/soc/nps/common.h b/include/soc/nps/common.h
index 9b1d43d671a3..8c18dc6d3fde 100644
--- a/include/soc/nps/common.h
+++ b/include/soc/nps/common.h
@@ -45,6 +45,12 @@
#define CTOP_INST_MOV2B_FLIP_R3_B1_B2_INST 0x5B60
#define CTOP_INST_MOV2B_FLIP_R3_B1_B2_LIMM 0x00010422
+#ifndef AUX_IENABLE
+#define AUX_IENABLE 0x40c
+#endif
+
+#define CTOP_AUX_IACK (0xFFFFF800 + 0x088)
+
#ifndef __ASSEMBLY__
/* In order to increase compilation test coverage */
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] irqchip/eznps: Fix build error for !ARC700 builds
2020-08-24 23:01 [PATCH] irqchip/eznps: Fix build error for !ARC700 builds Vineet Gupta
@ 2020-08-25 7:21 ` Sebastian Andrzej Siewior
2020-08-25 18:05 ` [PATCH v2] " Vineet Gupta
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2020-08-25 7:21 UTC (permalink / raw)
To: Vineet Gupta; +Cc: linux-snps-arc, linux-kernel, oferle, kernel test robot
On 2020-08-24 16:01:49 [-0700], Vineet Gupta wrote:
A little of patch description wouldn't hurt. Especially since it is not
a simple move but IENABLE comes out of nowhere.
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Link: http://lists.infradead.org/pipermail/linux-snps-arc/2020-August/004032.html
That link gets lost if someone decides to recreate the pipermail archive
and you have no hint what it was. Using
Link: https://lkml.kernel.org/r/20200824095831.5lpkmkafelnvlpi2@linutronix.de
instead will instead give you the message-id in case lore dies or the
lkml.kernel.org redirect service goes into retirement.
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
> ---
> arch/arc/plat-eznps/include/plat/ctop.h | 1 -
> include/soc/nps/common.h | 6 ++++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arc/plat-eznps/include/plat/ctop.h b/arch/arc/plat-eznps/include/plat/ctop.h
> index a4a61531c7fb..77712c5ffe84 100644
> --- a/arch/arc/plat-eznps/include/plat/ctop.h
> +++ b/arch/arc/plat-eznps/include/plat/ctop.h
> @@ -33,7 +33,6 @@
> #define CTOP_AUX_DPC (CTOP_AUX_BASE + 0x02C)
> #define CTOP_AUX_LPC (CTOP_AUX_BASE + 0x030)
> #define CTOP_AUX_EFLAGS (CTOP_AUX_BASE + 0x080)
> -#define CTOP_AUX_IACK (CTOP_AUX_BASE + 0x088)
> #define CTOP_AUX_GPA1 (CTOP_AUX_BASE + 0x08C)
> #define CTOP_AUX_UDMC (CTOP_AUX_BASE + 0x300)
>
> diff --git a/include/soc/nps/common.h b/include/soc/nps/common.h
> index 9b1d43d671a3..8c18dc6d3fde 100644
> --- a/include/soc/nps/common.h
> +++ b/include/soc/nps/common.h
> @@ -45,6 +45,12 @@
> #define CTOP_INST_MOV2B_FLIP_R3_B1_B2_INST 0x5B60
> #define CTOP_INST_MOV2B_FLIP_R3_B1_B2_LIMM 0x00010422
>
> +#ifndef AUX_IENABLE
> +#define AUX_IENABLE 0x40c
> +#endif
> +
> +#define CTOP_AUX_IACK (0xFFFFF800 + 0x088)
> +
> #ifndef __ASSEMBLY__
>
> /* In order to increase compilation test coverage */
Sebastian
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] irqchip/eznps: Fix build error for !ARC700 builds
2020-08-25 7:21 ` Sebastian Andrzej Siewior
@ 2020-08-25 18:05 ` Vineet Gupta
2020-08-27 7:01 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 4+ messages in thread
From: Vineet Gupta @ 2020-08-25 18:05 UTC (permalink / raw)
To: linux-snps-arc
Cc: linux-kernel, Vineet Gupta, kernel test robot, Sebastian Andrzej Siewior
eznps driver is supposed to be platform independent however it ends up
including stuff from inside arch/arc headers leading to rand config
build errors.
Fix this specific reported error as quick hacks as the correct fixes are
too much work:
- copy AUX_IENABLE from arch/arc header
- move CTOP_AUX_IACK from platform header
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://lkml.kernel.org/r/20200824095831.5lpkmkafelnvlpi2@linutronix.de
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
arch/arc/plat-eznps/include/plat/ctop.h | 1 -
include/soc/nps/common.h | 6 ++++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arc/plat-eznps/include/plat/ctop.h b/arch/arc/plat-eznps/include/plat/ctop.h
index a4a61531c7fb..77712c5ffe84 100644
--- a/arch/arc/plat-eznps/include/plat/ctop.h
+++ b/arch/arc/plat-eznps/include/plat/ctop.h
@@ -33,7 +33,6 @@
#define CTOP_AUX_DPC (CTOP_AUX_BASE + 0x02C)
#define CTOP_AUX_LPC (CTOP_AUX_BASE + 0x030)
#define CTOP_AUX_EFLAGS (CTOP_AUX_BASE + 0x080)
-#define CTOP_AUX_IACK (CTOP_AUX_BASE + 0x088)
#define CTOP_AUX_GPA1 (CTOP_AUX_BASE + 0x08C)
#define CTOP_AUX_UDMC (CTOP_AUX_BASE + 0x300)
diff --git a/include/soc/nps/common.h b/include/soc/nps/common.h
index 9b1d43d671a3..8c18dc6d3fde 100644
--- a/include/soc/nps/common.h
+++ b/include/soc/nps/common.h
@@ -45,6 +45,12 @@
#define CTOP_INST_MOV2B_FLIP_R3_B1_B2_INST 0x5B60
#define CTOP_INST_MOV2B_FLIP_R3_B1_B2_LIMM 0x00010422
+#ifndef AUX_IENABLE
+#define AUX_IENABLE 0x40c
+#endif
+
+#define CTOP_AUX_IACK (0xFFFFF800 + 0x088)
+
#ifndef __ASSEMBLY__
/* In order to increase compilation test coverage */
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] irqchip/eznps: Fix build error for !ARC700 builds
2020-08-25 18:05 ` [PATCH v2] " Vineet Gupta
@ 2020-08-27 7:01 ` Sebastian Andrzej Siewior
0 siblings, 0 replies; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2020-08-27 7:01 UTC (permalink / raw)
To: Vineet Gupta; +Cc: linux-snps-arc, linux-kernel, kernel test robot
On 2020-08-25 11:05:18 [-0700], Vineet Gupta wrote:
> eznps driver is supposed to be platform independent however it ends up
> including stuff from inside arch/arc headers leading to rand config
> build errors.
>
> Fix this specific reported error as quick hacks as the correct fixes are
> too much work:
> - copy AUX_IENABLE from arch/arc header
> - move CTOP_AUX_IACK from platform header
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Link: https://lkml.kernel.org/r/20200824095831.5lpkmkafelnvlpi2@linutronix.de
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
Thank you.
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
in case it is not too late :)
Sebastian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-27 7:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-24 23:01 [PATCH] irqchip/eznps: Fix build error for !ARC700 builds Vineet Gupta
2020-08-25 7:21 ` Sebastian Andrzej Siewior
2020-08-25 18:05 ` [PATCH v2] " Vineet Gupta
2020-08-27 7:01 ` Sebastian Andrzej Siewior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®