* [PATCH net] net: dp83867: Fix WoL SecureOn password
@ 2020-09-02 19:27 Dan Murphy
2020-09-02 19:58 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Murphy @ 2020-09-02 19:27 UTC (permalink / raw)
To: davem, andrew, f.fainelli, hkallweit1; +Cc: netdev, linux-kernel, Dan Murphy
Fix the registers being written to as the values were being over written
when writing the same registers.
Fixes: caabee5b53f5 ("net: phy: dp83867: support Wake on LAN")
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
drivers/net/phy/dp83867.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index f3c04981b8da..cd7032628a28 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -215,9 +215,9 @@ static int dp83867_set_wol(struct phy_device *phydev,
if (wol->wolopts & WAKE_MAGICSECURE) {
phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_RXFSOP1,
(wol->sopass[1] << 8) | wol->sopass[0]);
- phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_RXFSOP1,
+ phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_RXFSOP2,
(wol->sopass[3] << 8) | wol->sopass[2]);
- phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_RXFSOP1,
+ phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_RXFSOP3,
(wol->sopass[5] << 8) | wol->sopass[4]);
val_rxcfg |= DP83867_WOL_SEC_EN;
--
2.28.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: dp83867: Fix WoL SecureOn password
2020-09-02 19:27 [PATCH net] net: dp83867: Fix WoL SecureOn password Dan Murphy
@ 2020-09-02 19:58 ` Andrew Lunn
2020-09-02 20:12 ` Florian Fainelli
2020-09-02 23:08 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2020-09-02 19:58 UTC (permalink / raw)
To: Dan Murphy; +Cc: davem, f.fainelli, hkallweit1, netdev, linux-kernel
On Wed, Sep 02, 2020 at 02:27:04PM -0500, Dan Murphy wrote:
> Fix the registers being written to as the values were being over written
> when writing the same registers.
>
> Fixes: caabee5b53f5 ("net: phy: dp83867: support Wake on LAN")
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: dp83867: Fix WoL SecureOn password
2020-09-02 19:27 [PATCH net] net: dp83867: Fix WoL SecureOn password Dan Murphy
2020-09-02 19:58 ` Andrew Lunn
@ 2020-09-02 20:12 ` Florian Fainelli
2020-09-02 23:08 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2020-09-02 20:12 UTC (permalink / raw)
To: Dan Murphy, davem, andrew, hkallweit1; +Cc: netdev, linux-kernel
On 9/2/2020 12:27 PM, Dan Murphy wrote:
> Fix the registers being written to as the values were being over written
> when writing the same registers.
>
> Fixes: caabee5b53f5 ("net: phy: dp83867: support Wake on LAN")
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: dp83867: Fix WoL SecureOn password
2020-09-02 19:27 [PATCH net] net: dp83867: Fix WoL SecureOn password Dan Murphy
2020-09-02 19:58 ` Andrew Lunn
2020-09-02 20:12 ` Florian Fainelli
@ 2020-09-02 23:08 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-09-02 23:08 UTC (permalink / raw)
To: dmurphy; +Cc: andrew, f.fainelli, hkallweit1, netdev, linux-kernel
From: Dan Murphy <dmurphy@ti.com>
Date: Wed, 2 Sep 2020 14:27:04 -0500
> Fix the registers being written to as the values were being over written
> when writing the same registers.
>
> Fixes: caabee5b53f5 ("net: phy: dp83867: support Wake on LAN")
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-02 23:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 19:27 [PATCH net] net: dp83867: Fix WoL SecureOn password Dan Murphy
2020-09-02 19:58 ` Andrew Lunn
2020-09-02 20:12 ` Florian Fainelli
2020-09-02 23:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®