* [PATCH] ipmi: add a newline when printing parameter 'panic_op' by sysfs
@ 2020-09-03 11:01 Xiongfeng Wang
2020-09-03 19:31 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Xiongfeng Wang @ 2020-09-03 11:01 UTC (permalink / raw)
To: minyard, arnd, gregkh; +Cc: openipmi-developer, linux-kernel, wangxiongfeng2
When I cat ipmi_msghandler parameter 'panic_op' by sysfs, it displays as
follows. It's better to add a newline for easy reading.
root@(none):/# cat /sys/module/ipmi_msghandler/parameters/panic_op
noneroot@(none):/#
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
---
drivers/char/ipmi/ipmi_msghandler.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index 737c0b6..6ebb549 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -89,19 +89,19 @@ static int panic_op_read_handler(char *buffer, const struct kernel_param *kp)
{
switch (ipmi_send_panic_event) {
case IPMI_SEND_PANIC_EVENT_NONE:
- strcpy(buffer, "none");
+ strcpy(buffer, "none\n");
break;
case IPMI_SEND_PANIC_EVENT:
- strcpy(buffer, "event");
+ strcpy(buffer, "event\n");
break;
case IPMI_SEND_PANIC_EVENT_STRING:
- strcpy(buffer, "string");
+ strcpy(buffer, "string\n");
break;
default:
- strcpy(buffer, "???");
+ strcpy(buffer, "???\n");
break;
}
--
1.7.12.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ipmi: add a newline when printing parameter 'panic_op' by sysfs
2020-09-03 11:01 [PATCH] ipmi: add a newline when printing parameter 'panic_op' by sysfs Xiongfeng Wang
@ 2020-09-03 19:31 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2020-09-03 19:31 UTC (permalink / raw)
To: Xiongfeng Wang; +Cc: arnd, gregkh, openipmi-developer, linux-kernel
On Thu, Sep 03, 2020 at 07:01:13PM +0800, Xiongfeng Wang wrote:
> When I cat ipmi_msghandler parameter 'panic_op' by sysfs, it displays as
> follows. It's better to add a newline for easy reading.
>
> root@(none):/# cat /sys/module/ipmi_msghandler/parameters/panic_op
> noneroot@(none):/#
Thanks, it's in my for-next queue.
-corey
>
> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 737c0b6..6ebb549 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -89,19 +89,19 @@ static int panic_op_read_handler(char *buffer, const struct kernel_param *kp)
> {
> switch (ipmi_send_panic_event) {
> case IPMI_SEND_PANIC_EVENT_NONE:
> - strcpy(buffer, "none");
> + strcpy(buffer, "none\n");
> break;
>
> case IPMI_SEND_PANIC_EVENT:
> - strcpy(buffer, "event");
> + strcpy(buffer, "event\n");
> break;
>
> case IPMI_SEND_PANIC_EVENT_STRING:
> - strcpy(buffer, "string");
> + strcpy(buffer, "string\n");
> break;
>
> default:
> - strcpy(buffer, "???");
> + strcpy(buffer, "???\n");
> break;
> }
>
> --
> 1.7.12.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-03 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 11:01 [PATCH] ipmi: add a newline when printing parameter 'panic_op' by sysfs Xiongfeng Wang
2020-09-03 19:31 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®