From: "Clément Péron" <peron.clem@gmail.com>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: devicetree@vger.kernel.org,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
"Takashi Iwai" <tiwai@suse.com>,
"Marcus Cooper" <codekipper@gmail.com>,
linux-sunxi@googlegroups.com,
linux-arm-kernel@lists.infradead.org,
"Clément Péron" <peron.clem@gmail.com>
Subject: [PATCH v2 01/20] Revert "ASoC: sun4i-i2s: Fix the LRCK polarity"
Date: Thu, 3 Sep 2020 22:30:15 +0200 [thread overview]
Message-ID: <20200903203034.1057334-2-peron.clem@gmail.com> (raw)
In-Reply-To: <20200903203034.1057334-1-peron.clem@gmail.com>
This reverts commit dd657eae8164f7e4bafe8b875031a7c6c50646a9.
There was a misinterpretation of the analysis using a scope.
After rechecking this using a logical analyzer the LRCK polarity is
fine.
Fixes: dd657eae8164 ("ASoC: sun4i-i2s: Fix the LRCK polarity")
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
sound/soc/sunxi/sun4i-i2s.c | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index f23ff29e7c1d..fabff7bcccbc 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -603,29 +603,23 @@ static int sun8i_i2s_set_soc_fmt(const struct sun4i_i2s *i2s,
u32 mode, val;
u8 offset;
- /*
- * DAI clock polarity
- *
- * The setup for LRCK contradicts the datasheet, but under a
- * scope it's clear that the LRCK polarity is reversed
- * compared to the expected polarity on the bus.
- */
+ /* DAI clock polarity */
switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
case SND_SOC_DAIFMT_IB_IF:
/* Invert both clocks */
- val = SUN8I_I2S_FMT0_BCLK_POLARITY_INVERTED;
+ val = SUN8I_I2S_FMT0_BCLK_POLARITY_INVERTED |
+ SUN8I_I2S_FMT0_LRCLK_POLARITY_INVERTED;
break;
case SND_SOC_DAIFMT_IB_NF:
/* Invert bit clock */
- val = SUN8I_I2S_FMT0_BCLK_POLARITY_INVERTED |
- SUN8I_I2S_FMT0_LRCLK_POLARITY_INVERTED;
+ val = SUN8I_I2S_FMT0_BCLK_POLARITY_INVERTED;
break;
case SND_SOC_DAIFMT_NB_IF:
/* Invert frame clock */
- val = 0;
+ val = SUN8I_I2S_FMT0_LRCLK_POLARITY_INVERTED;
break;
case SND_SOC_DAIFMT_NB_NF:
- val = SUN8I_I2S_FMT0_LRCLK_POLARITY_INVERTED;
+ val = 0;
break;
default:
return -EINVAL;
--
2.25.1
next prev parent reply other threads:[~2020-09-03 20:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 20:30 [PATCH v2 00/20] Add Allwinner H3/H5/H6/A64 HDMI audio Clément Péron
2020-09-03 20:30 ` Clément Péron [this message]
2020-09-03 20:57 ` [PATCH v2 01/20] Revert "ASoC: sun4i-i2s: Fix the LRCK polarity" Maxime Ripard
2020-09-03 20:30 ` [PATCH v2 02/20] ASoC: sun4i-i2s: Add support for H6 I2S Clément Péron
2020-09-04 3:16 ` Samuel Holland
2020-09-05 9:44 ` Clément Péron
2020-09-03 20:30 ` [PATCH v2 03/20] ASoC: sun4i-i2s: Adjust LRCLK width Clément Péron
2020-09-04 3:18 ` Samuel Holland
2020-09-03 20:30 ` [PATCH v2 04/20] dt-bindings: ASoC: sun4i-i2s: Add H6 compatible Clément Péron
2020-09-03 20:30 ` [PATCH v2 05/20] ASoC: sun4i-i2s: Set sign extend sample Clément Péron
2020-09-03 20:30 ` [PATCH v2 06/20] ASoc: sun4i-i2s: Add 20 and 24 bit support Clément Péron
2020-09-03 20:30 ` [PATCH v2 07/20] ASoC: sun4i-i2s: Fix sun8i volatile regs Clément Péron
2020-09-03 20:30 ` [PATCH v2 08/20] arm64: dts: allwinner: h6: Add HDMI audio node Clément Péron
2020-09-03 20:30 ` [PATCH v2 09/20] arm64: dts: allwinner: h6: Enable HDMI sound for Beelink GS1 Clément Péron
2020-09-03 20:30 ` [PATCH v2 10/20] arm: dts: sunxi: h3/h5: Add DAI node for HDMI Clément Péron
2020-09-03 20:30 ` [PATCH v2 11/20] arm: dts: sunxi: h3/h5: Add HDMI audio Clément Péron
2020-09-03 20:30 ` [PATCH v2 12/20] arm64: dts: allwinner: a64: Add DAI node for HDMI Clément Péron
2020-09-03 20:30 ` [PATCH v2 13/20] arm64: dts: allwinner: a64: Add HDMI audio Clément Péron
2020-09-03 20:30 ` [PATCH v2 14/20] arm: sun8i: h3: Add HDMI audio to Orange Pi 2 Clément Péron
2020-09-03 20:30 ` [PATCH v2 15/20] arm: sun8i: h3: Add HDMI audio to Beelink X2 Clément Péron
2020-09-03 20:30 ` [PATCH v2 16/20] arm64: dts: allwinner: a64: Add HDMI audio to Pine64 Clément Péron
2020-09-03 20:30 ` [PATCH v2 17/20] arm64: dts: allwinner: Enable HDMI audio on Orange Pi PC 2 Clément Péron
2020-09-03 20:30 ` [PATCH v2 18/20] ARM: dts: sun8i-h3: Enable HDMI audio on Orange Pi PC/One Clément Péron
2020-09-03 20:30 ` [PATCH v2 19/20] arm64: dts: sun50i-h6-orangepi-3: Enable HDMI audio Clément Péron
2020-09-03 20:30 ` [PATCH v2 20/20] arm64: defconfig: Enable Allwinner i2s driver Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903203034.1057334-2-peron.clem@gmail.com \
--to=peron.clem@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=codekipper@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®