mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net-next] can: kvaser_pciefd: Remove unused macro KVASER_PCIEFD_KCAN_CTRL_EFRAME
@ 2020-09-04 13:10 Wang Hai
  2020-09-15  6:31 ` Marc Kleine-Budde
  0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2020-09-04 13:10 UTC (permalink / raw)
  To: wg, mkl, davem, kuba; +Cc: linux-can, netdev, linux-kernel

KVASER_PCIEFD_KCAN_CTRL_EFRAME is never used after it was introduced.
So better to remove it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
 drivers/net/can/kvaser_pciefd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c
index 6f766918211a..c0b18ff107c7 100644
--- a/drivers/net/can/kvaser_pciefd.c
+++ b/drivers/net/can/kvaser_pciefd.c
@@ -131,7 +131,6 @@ MODULE_DESCRIPTION("CAN driver for Kvaser CAN/PCIe devices");
 
 /* Kvaser KCAN definitions */
 #define KVASER_PCIEFD_KCAN_CTRL_EFLUSH (4 << 29)
-#define KVASER_PCIEFD_KCAN_CTRL_EFRAME (5 << 29)
 
 #define KVASER_PCIEFD_KCAN_CMD_SEQ_SHIFT 16
 /* Request status packet */
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] can: kvaser_pciefd: Remove unused macro KVASER_PCIEFD_KCAN_CTRL_EFRAME
  2020-09-04 13:10 [PATCH net-next] can: kvaser_pciefd: Remove unused macro KVASER_PCIEFD_KCAN_CTRL_EFRAME Wang Hai
@ 2020-09-15  6:31 ` Marc Kleine-Budde
  0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2020-09-15  6:31 UTC (permalink / raw)
  To: Wang Hai, wg, davem, kuba; +Cc: linux-can, netdev, linux-kernel


[-- Attachment #1.1: Type: text/plain, Size: 1188 bytes --]

On 9/4/20 3:10 PM, Wang Hai wrote:
> KVASER_PCIEFD_KCAN_CTRL_EFRAME is never used after it was introduced.
> So better to remove it.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
>  drivers/net/can/kvaser_pciefd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c
> index 6f766918211a..c0b18ff107c7 100644
> --- a/drivers/net/can/kvaser_pciefd.c
> +++ b/drivers/net/can/kvaser_pciefd.c
> @@ -131,7 +131,6 @@ MODULE_DESCRIPTION("CAN driver for Kvaser CAN/PCIe devices");
>  
>  /* Kvaser KCAN definitions */
>  #define KVASER_PCIEFD_KCAN_CTRL_EFLUSH (4 << 29)
> -#define KVASER_PCIEFD_KCAN_CTRL_EFRAME (5 << 29)
>  
>  #define KVASER_PCIEFD_KCAN_CMD_SEQ_SHIFT 16
>  /* Request status packet */
> 

I'd like to keep this for documentation purpose, too.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-15  6:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-04 13:10 [PATCH net-next] can: kvaser_pciefd: Remove unused macro KVASER_PCIEFD_KCAN_CTRL_EFRAME Wang Hai
2020-09-15  6:31 ` Marc Kleine-Budde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®