* [PATCH v2 2/2] staging: gdm724x: gdm_tty: replaced macro with a function
@ 2020-09-02 16:16 Antoni Przybylik
2020-09-02 16:21 ` Randy Dunlap
2020-09-04 13:38 ` Greg KH
0 siblings, 2 replies; 5+ messages in thread
From: Antoni Przybylik @ 2020-09-02 16:16 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Antoni Przybylik
Changed return type to bool and removed inline specifier. Also added
static specifier.
Signed-off-by: Antoni Przybylik <antoni.przybylik@wp.pl>
---
drivers/staging/gdm724x/gdm_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index 34a13d98c029..179fc9b9400b 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -34,7 +34,7 @@ static DEFINE_MUTEX(gdm_table_lock);
static const char *DRIVER_STRING[TTY_MAX_COUNT] = {"GCTATC", "GCTDM"};
static char *DEVICE_STRING[TTY_MAX_COUNT] = {"GCT-ATC", "GCT-DM"};
-inline int gdm_tty_ready(struct gdm *gdm)
+static bool gdm_tty_ready(struct gdm *gdm)
{
return (gdm && gdm->tty_dev && gdm->port.count);
}
--
2.28.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2 2/2] staging: gdm724x: gdm_tty: replaced macro with a function
2020-09-02 16:16 [PATCH v2 2/2] staging: gdm724x: gdm_tty: replaced macro with a function Antoni Przybylik
@ 2020-09-02 16:21 ` Randy Dunlap
2020-09-02 17:07 ` antoni.przybylik
2020-09-04 13:38 ` Greg KH
1 sibling, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2020-09-02 16:21 UTC (permalink / raw)
To: Antoni Przybylik, gregkh; +Cc: devel, linux-kernel
On 9/2/20 9:16 AM, Antoni Przybylik wrote:
> Changed return type to bool and removed inline specifier. Also added
> static specifier.
why remove the inline specifier?
thanks.
> Signed-off-by: Antoni Przybylik <antoni.przybylik@wp.pl>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index 34a13d98c029..179fc9b9400b 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -34,7 +34,7 @@ static DEFINE_MUTEX(gdm_table_lock);
> static const char *DRIVER_STRING[TTY_MAX_COUNT] = {"GCTATC", "GCTDM"};
> static char *DEVICE_STRING[TTY_MAX_COUNT] = {"GCT-ATC", "GCT-DM"};
>
> -inline int gdm_tty_ready(struct gdm *gdm)
> +static bool gdm_tty_ready(struct gdm *gdm)
> {
> return (gdm && gdm->tty_dev && gdm->port.count);
> }
>
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2 2/2] staging: gdm724x: gdm_tty: replaced macro with a function
2020-09-02 16:21 ` Randy Dunlap
@ 2020-09-02 17:07 ` antoni.przybylik
2020-09-02 17:14 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: antoni.przybylik @ 2020-09-02 17:07 UTC (permalink / raw)
To: Randy Dunlap; +Cc: devel, linux-kernel
On 02.09.2020 18:21, Randy Dunlap wrote:
> On 9/2/20 9:16 AM, Antoni Przybylik wrote:
>> Changed return type to bool and removed inline specifier. Also added
>> static specifier.
> why remove the inline specifier?
Greg KH wrote to me:
And really, no need to make it inline, just make it a normal function
and the compiler will inline it if needed.
> thanks.
>
>> Signed-off-by: Antoni Przybylik <antoni.przybylik@wp.pl>
>> ---
>> drivers/staging/gdm724x/gdm_tty.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
>> index 34a13d98c029..179fc9b9400b 100644
>> --- a/drivers/staging/gdm724x/gdm_tty.c
>> +++ b/drivers/staging/gdm724x/gdm_tty.c
>> @@ -34,7 +34,7 @@ static DEFINE_MUTEX(gdm_table_lock);
>> static const char *DRIVER_STRING[TTY_MAX_COUNT] = {"GCTATC", "GCTDM"};
>> static char *DEVICE_STRING[TTY_MAX_COUNT] = {"GCT-ATC", "GCT-DM"};
>>
>> -inline int gdm_tty_ready(struct gdm *gdm)
>> +static bool gdm_tty_ready(struct gdm *gdm)
>> {
>> return (gdm && gdm->tty_dev && gdm->port.count);
>> }
>>
>
Antoni Przybylik
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2 2/2] staging: gdm724x: gdm_tty: replaced macro with a function
2020-09-02 17:07 ` antoni.przybylik
@ 2020-09-02 17:14 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2020-09-02 17:14 UTC (permalink / raw)
To: antoni.przybylik; +Cc: devel, linux-kernel
On 9/2/20 10:07 AM, antoni.przybylik@wp.pl wrote:
> On 02.09.2020 18:21, Randy Dunlap wrote:
>> On 9/2/20 9:16 AM, Antoni Przybylik wrote:
>>> Changed return type to bool and removed inline specifier. Also added
>>> static specifier.
>> why remove the inline specifier?
>
> Greg KH wrote to me:
>
> And really, no need to make it inline, just make it a normal function
> and the compiler will inline it if needed.
>
>> thanks.
OK, thanks.
Sometimes the compiler will also ignore inline if it wants to.
That's why we have to use __always_inline.
>>
>>> Signed-off-by: Antoni Przybylik <antoni.przybylik@wp.pl>
>>> ---
>>> drivers/staging/gdm724x/gdm_tty.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
>>> index 34a13d98c029..179fc9b9400b 100644
>>> --- a/drivers/staging/gdm724x/gdm_tty.c
>>> +++ b/drivers/staging/gdm724x/gdm_tty.c
>>> @@ -34,7 +34,7 @@ static DEFINE_MUTEX(gdm_table_lock);
>>> static const char *DRIVER_STRING[TTY_MAX_COUNT] = {"GCTATC", "GCTDM"};
>>> static char *DEVICE_STRING[TTY_MAX_COUNT] = {"GCT-ATC", "GCT-DM"};
>>> -inline int gdm_tty_ready(struct gdm *gdm)
>>> +static bool gdm_tty_ready(struct gdm *gdm)
>>> {
>>> return (gdm && gdm->tty_dev && gdm->port.count);
>>> }
>>>
>>
> Antoni Przybylik
--
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] staging: gdm724x: gdm_tty: replaced macro with a function
2020-09-02 16:16 [PATCH v2 2/2] staging: gdm724x: gdm_tty: replaced macro with a function Antoni Przybylik
2020-09-02 16:21 ` Randy Dunlap
@ 2020-09-04 13:38 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2020-09-04 13:38 UTC (permalink / raw)
To: Antoni Przybylik; +Cc: devel, linux-kernel
On Wed, Sep 02, 2020 at 06:16:27PM +0200, Antoni Przybylik wrote:
> Changed return type to bool and removed inline specifier. Also added
> static specifier.
>
> Signed-off-by: Antoni Przybylik <antoni.przybylik@wp.pl>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You sent 2 patches with the identical subject line, yet they did
different things :(
Please fix them both up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-04 13:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-02 16:16 [PATCH v2 2/2] staging: gdm724x: gdm_tty: replaced macro with a function Antoni Przybylik
2020-09-02 16:21 ` Randy Dunlap
2020-09-02 17:07 ` antoni.przybylik
2020-09-02 17:14 ` Randy Dunlap
2020-09-04 13:38 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®