* [PATCH net-next] cipso: fix 'audit_secid' kernel-doc warning in cipso_ipv4.c
@ 2020-09-08 13:59 Wang Hai
2020-09-08 21:22 ` Paul Moore
2020-09-09 3:03 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wang Hai @ 2020-09-08 13:59 UTC (permalink / raw)
To: paul, davem, kuznet, yoshfuji, kuba
Cc: netdev, linux-kernel, linux-security-module
Fixes the following W=1 kernel build warning(s):
net/ipv4/cipso_ipv4.c:510: warning: Excess function parameter 'audit_secid' description in 'cipso_v4_doi_remove'
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
net/ipv4/cipso_ipv4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c
index 2eb71579f4d2..471d33a0d095 100644
--- a/net/ipv4/cipso_ipv4.c
+++ b/net/ipv4/cipso_ipv4.c
@@ -498,7 +498,7 @@ static void cipso_v4_doi_free_rcu(struct rcu_head *entry)
/**
* cipso_v4_doi_remove - Remove an existing DOI from the CIPSO protocol engine
* @doi: the DOI value
- * @audit_secid: the LSM secid to use in the audit message
+ * @audit_info: NetLabel audit information
*
* Description:
* Removes a DOI definition from the CIPSO engine. The NetLabel routines will
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] cipso: fix 'audit_secid' kernel-doc warning in cipso_ipv4.c
2020-09-08 13:59 [PATCH net-next] cipso: fix 'audit_secid' kernel-doc warning in cipso_ipv4.c Wang Hai
@ 2020-09-08 21:22 ` Paul Moore
2020-09-09 3:03 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Paul Moore @ 2020-09-08 21:22 UTC (permalink / raw)
To: Wang Hai
Cc: davem, kuznet, yoshfuji, kuba, netdev, linux-kernel,
linux-security-module
On Tue, Sep 8, 2020 at 10:02 AM Wang Hai <wanghai38@huawei.com> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> net/ipv4/cipso_ipv4.c:510: warning: Excess function parameter 'audit_secid' description in 'cipso_v4_doi_remove'
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
> net/ipv4/cipso_ipv4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for catching this and submitting the fix.
Acked-by: Paul Moore <paul@paul-moore.com>
> diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c
> index 2eb71579f4d2..471d33a0d095 100644
> --- a/net/ipv4/cipso_ipv4.c
> +++ b/net/ipv4/cipso_ipv4.c
> @@ -498,7 +498,7 @@ static void cipso_v4_doi_free_rcu(struct rcu_head *entry)
> /**
> * cipso_v4_doi_remove - Remove an existing DOI from the CIPSO protocol engine
> * @doi: the DOI value
> - * @audit_secid: the LSM secid to use in the audit message
> + * @audit_info: NetLabel audit information
> *
> * Description:
> * Removes a DOI definition from the CIPSO engine. The NetLabel routines will
> --
> 2.17.1
>
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] cipso: fix 'audit_secid' kernel-doc warning in cipso_ipv4.c
2020-09-08 13:59 [PATCH net-next] cipso: fix 'audit_secid' kernel-doc warning in cipso_ipv4.c Wang Hai
2020-09-08 21:22 ` Paul Moore
@ 2020-09-09 3:03 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-09-09 3:03 UTC (permalink / raw)
To: wanghai38
Cc: paul, kuznet, yoshfuji, kuba, netdev, linux-kernel,
linux-security-module
From: Wang Hai <wanghai38@huawei.com>
Date: Tue, 8 Sep 2020 21:59:15 +0800
> Fixes the following W=1 kernel build warning(s):
>
> net/ipv4/cipso_ipv4.c:510: warning: Excess function parameter 'audit_secid' description in 'cipso_v4_doi_remove'
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-09 3:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 13:59 [PATCH net-next] cipso: fix 'audit_secid' kernel-doc warning in cipso_ipv4.c Wang Hai
2020-09-08 21:22 ` Paul Moore
2020-09-09 3:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®