* [PATCH] fib: fix fib_rule_ops indirect call wrappers when CONFIG_IPV6=m
@ 2020-09-08 16:18 Brian Vazquez
2020-09-09 3:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Brian Vazquez @ 2020-09-08 16:18 UTC (permalink / raw)
To: Brian Vazquez, Brian Vazquez, Eric Dumazet, David S . Miller
Cc: linux-kernel, netdev, Sven Joachim, Randy Dunlap
If CONFIG_IPV6=m, the IPV6 functions won't be found by the linker:
ld: net/core/fib_rules.o: in function `fib_rules_lookup':
fib_rules.c:(.text+0x606): undefined reference to `fib6_rule_match'
ld: fib_rules.c:(.text+0x611): undefined reference to `fib6_rule_match'
ld: fib_rules.c:(.text+0x68c): undefined reference to `fib6_rule_action'
ld: fib_rules.c:(.text+0x693): undefined reference to `fib6_rule_action'
ld: fib_rules.c:(.text+0x6aa): undefined reference to `fib6_rule_suppress'
ld: fib_rules.c:(.text+0x6bc): undefined reference to `fib6_rule_suppress'
make: *** [Makefile:1166: vmlinux] Error 1
Reported-by: Sven Joachim <svenjoac@gmx.de>
Fixes: b9aaec8f0be5 ("fib: use indirect call wrappers in the most common fib_rules_ops")
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Signed-off-by: Brian Vazquez <brianvv@google.com>
---
net/core/fib_rules.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c
index 51678a528f85..7bcfb16854cb 100644
--- a/net/core/fib_rules.c
+++ b/net/core/fib_rules.c
@@ -16,7 +16,7 @@
#include <net/ip_tunnels.h>
#include <linux/indirect_call_wrapper.h>
-#ifdef CONFIG_IPV6_MULTIPLE_TABLES
+#if defined(CONFIG_IPV6) && defined(CONFIG_IPV6_MULTIPLE_TABLES)
#ifdef CONFIG_IP_MULTIPLE_TABLES
#define INDIRECT_CALL_MT(f, f2, f1, ...) \
INDIRECT_CALL_INET(f, f2, f1, __VA_ARGS__)
--
2.28.0.526.ge36021eeef-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fib: fix fib_rule_ops indirect call wrappers when CONFIG_IPV6=m
2020-09-08 16:18 [PATCH] fib: fix fib_rule_ops indirect call wrappers when CONFIG_IPV6=m Brian Vazquez
@ 2020-09-09 3:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-09-09 3:09 UTC (permalink / raw)
To: brianvv; +Cc: brianvv.kernel, edumazet, linux-kernel, netdev, svenjoac, rdunlap
From: Brian Vazquez <brianvv@google.com>
Date: Tue, 8 Sep 2020 09:18:12 -0700
> If CONFIG_IPV6=m, the IPV6 functions won't be found by the linker:
>
> ld: net/core/fib_rules.o: in function `fib_rules_lookup':
> fib_rules.c:(.text+0x606): undefined reference to `fib6_rule_match'
> ld: fib_rules.c:(.text+0x611): undefined reference to `fib6_rule_match'
> ld: fib_rules.c:(.text+0x68c): undefined reference to `fib6_rule_action'
> ld: fib_rules.c:(.text+0x693): undefined reference to `fib6_rule_action'
> ld: fib_rules.c:(.text+0x6aa): undefined reference to `fib6_rule_suppress'
> ld: fib_rules.c:(.text+0x6bc): undefined reference to `fib6_rule_suppress'
> make: *** [Makefile:1166: vmlinux] Error 1
>
> Reported-by: Sven Joachim <svenjoac@gmx.de>
> Fixes: b9aaec8f0be5 ("fib: use indirect call wrappers in the most common fib_rules_ops")
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> Signed-off-by: Brian Vazquez <brianvv@google.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-09 3:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 16:18 [PATCH] fib: fix fib_rule_ops indirect call wrappers when CONFIG_IPV6=m Brian Vazquez
2020-09-09 3:09 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®