* Re: [PATCH] scripts: coccicheck: Do not use shift command when rule is specified
[not found] <036792a4-0454-732a-8a0e-83123713445c@web.de>
@ 2020-09-09 7:38 ` Sumera Priyadarsini
0 siblings, 0 replies; only message in thread
From: Sumera Priyadarsini @ 2020-09-09 7:38 UTC (permalink / raw)
To: Markus Elfring
Cc: Sumera Priyadarsini, Coccinelle, linux-kernel, kernel-janitors,
Gilles Muller, Julia Lawall, Masahiro Yamada, Michal Marek,
Nicolas Palix
On Wed, Sep 09, 2020 at 08:52:19AM +0200, Markus Elfring wrote:
> I find it helpful to avoid typos (like the following) in the change description.
>
>
> > … Makfeile. …
>
> … Makefile. …
>
>
> > … paasing …
>
> … passing …
>
>
> > …, resuting …
>
> …, resulting …
>
>
> > This patch modifies coccicheck …
>
I did make those errors but I also rectified them. This is strange
because my commit message shows the rectified version.
Either way, I will send a v2. Thanks for pointing this out.
> Would an imperative wording be preferred for the commit message?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=34d4ddd359dbcdf6c5fb3f85a179243d7a1cb7f8#n151
>
> Regards,
> Markus
^ permalink raw reply [flat|nested] only message in thread