* [PATCH -next] riscv/mm/fault: fix old-style-declaration warning
@ 2020-09-09 11:29 Wei Yongjun
2020-09-09 12:00 ` Pekka Enberg
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-09-09 11:29 UTC (permalink / raw)
To: Hulk Robot, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Pekka Enberg, Andrew Morton, Peter Xu, Daniel Jordan,
Michel Lespinasse, Mike Rapoport
Cc: Wei Yongjun, linux-riscv, linux-kernel
gcc report build warning as follows:
arch/riscv/mm/fault.c:81:1: warning:
'inline' is not at beginning of declaration [-Wold-style-declaration]
81 | static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
| ^~~~~~
This commit fix it by moving 'inline' after 'static'.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
arch/riscv/mm/fault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/mm/fault.c b/arch/riscv/mm/fault.c
index a23eaf5ce95c..a173432ccf82 100644
--- a/arch/riscv/mm/fault.c
+++ b/arch/riscv/mm/fault.c
@@ -78,7 +78,7 @@ static inline void bad_area(struct pt_regs *regs, struct mm_struct *mm, int code
no_context(regs, addr);
}
-static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
+static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
{
pgd_t *pgd, *pgd_k;
pud_t *pud, *pud_k;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH -next] riscv/mm/fault: fix old-style-declaration warning
2020-09-09 11:29 [PATCH -next] riscv/mm/fault: fix old-style-declaration warning Wei Yongjun
@ 2020-09-09 12:00 ` Pekka Enberg
0 siblings, 0 replies; 2+ messages in thread
From: Pekka Enberg @ 2020-09-09 12:00 UTC (permalink / raw)
To: Wei Yongjun
Cc: Hulk Robot, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Andrew Morton, Peter Xu, Daniel Jordan, Michel Lespinasse,
Mike Rapoport, linux-riscv, LKML
Hi,
On Wed, Sep 9, 2020 at 2:20 PM Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> gcc report build warning as follows:
>
> arch/riscv/mm/fault.c:81:1: warning:
> 'inline' is not at beginning of declaration [-Wold-style-declaration]
> 81 | static void inline vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
> | ^~~~~~
>
> This commit fix it by moving 'inline' after 'static'.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks for the fix, but Palmer committed similar fix from me to for-next:
https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?h=for-next&id=6f36a9635082e1d6910bc7853d0c9fd12d7890b5
- Pekka
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-09 12:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-09 11:29 [PATCH -next] riscv/mm/fault: fix old-style-declaration warning Wei Yongjun
2020-09-09 12:00 ` Pekka Enberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®