From: Lubomir Rintel <lkundrak@v3.sk>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>, Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mfd: ene-kb3930: Make symbol 'kb3930_power_off' static
Date: Wed, 9 Sep 2020 21:26:49 +0200 [thread overview]
Message-ID: <20200909192649.GA1105946@demiurge.local> (raw)
In-Reply-To: <20200909143253.66168-1-weiyongjun1@huawei.com>
On Wed, Sep 09, 2020 at 10:32:53PM +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/mfd/ene-kb3930.c:36:15: warning:
> symbol 'kb3930_power_off' was not declared. Should it be static?
>
> This variable is not used outside of ene-kb3930.c, this commit
> marks it static.
>
> Fixes: 753bd752e181 ("mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Lubomir Rintel <lkundrak@v3.sk>
Thank you!
Lubo
> ---
> drivers/mfd/ene-kb3930.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/ene-kb3930.c b/drivers/mfd/ene-kb3930.c
> index 1c32ff586816..eb7312bd6361 100644
> --- a/drivers/mfd/ene-kb3930.c
> +++ b/drivers/mfd/ene-kb3930.c
> @@ -33,7 +33,7 @@ struct kb3930 {
> struct gpio_descs *off_gpios;
> };
>
> -struct kb3930 *kb3930_power_off;
> +static struct kb3930 *kb3930_power_off;
>
> #define EC_GPIO_WAVE 0
> #define EC_GPIO_OFF_MODE 1
>
prev parent reply other threads:[~2020-09-09 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 14:32 Wei Yongjun
2020-09-09 19:26 ` Lubomir Rintel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909192649.GA1105946@demiurge.local \
--to=lkundrak@v3.sk \
--cc=hulkci@huawei.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®