* [PATCH -next] mfd: ene-kb3930: Make symbol 'kb3930_power_off' static
@ 2020-09-09 14:32 Wei Yongjun
2020-09-09 19:26 ` Lubomir Rintel
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-09-09 14:32 UTC (permalink / raw)
To: Hulk Robot, Lee Jones, Lubomir Rintel; +Cc: Wei Yongjun, linux-kernel
The sparse tool complains as follows:
drivers/mfd/ene-kb3930.c:36:15: warning:
symbol 'kb3930_power_off' was not declared. Should it be static?
This variable is not used outside of ene-kb3930.c, this commit
marks it static.
Fixes: 753bd752e181 ("mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/mfd/ene-kb3930.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/ene-kb3930.c b/drivers/mfd/ene-kb3930.c
index 1c32ff586816..eb7312bd6361 100644
--- a/drivers/mfd/ene-kb3930.c
+++ b/drivers/mfd/ene-kb3930.c
@@ -33,7 +33,7 @@ struct kb3930 {
struct gpio_descs *off_gpios;
};
-struct kb3930 *kb3930_power_off;
+static struct kb3930 *kb3930_power_off;
#define EC_GPIO_WAVE 0
#define EC_GPIO_OFF_MODE 1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] mfd: ene-kb3930: Make symbol 'kb3930_power_off' static
2020-09-09 14:32 [PATCH -next] mfd: ene-kb3930: Make symbol 'kb3930_power_off' static Wei Yongjun
@ 2020-09-09 19:26 ` Lubomir Rintel
0 siblings, 0 replies; 2+ messages in thread
From: Lubomir Rintel @ 2020-09-09 19:26 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Hulk Robot, Lee Jones, linux-kernel
On Wed, Sep 09, 2020 at 10:32:53PM +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/mfd/ene-kb3930.c:36:15: warning:
> symbol 'kb3930_power_off' was not declared. Should it be static?
>
> This variable is not used outside of ene-kb3930.c, this commit
> marks it static.
>
> Fixes: 753bd752e181 ("mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Lubomir Rintel <lkundrak@v3.sk>
Thank you!
Lubo
> ---
> drivers/mfd/ene-kb3930.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/ene-kb3930.c b/drivers/mfd/ene-kb3930.c
> index 1c32ff586816..eb7312bd6361 100644
> --- a/drivers/mfd/ene-kb3930.c
> +++ b/drivers/mfd/ene-kb3930.c
> @@ -33,7 +33,7 @@ struct kb3930 {
> struct gpio_descs *off_gpios;
> };
>
> -struct kb3930 *kb3930_power_off;
> +static struct kb3930 *kb3930_power_off;
>
> #define EC_GPIO_WAVE 0
> #define EC_GPIO_OFF_MODE 1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-09 19:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-09 14:32 [PATCH -next] mfd: ene-kb3930: Make symbol 'kb3930_power_off' static Wei Yongjun
2020-09-09 19:26 ` Lubomir Rintel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®