* [PATCH] nvme: tcp: fix kconfig dependency warning when !CRYPTO
@ 2020-09-14 15:01 Necip Fazil Yildiran
2020-09-14 19:24 ` Sagi Grimberg
2020-09-15 5:59 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Necip Fazil Yildiran @ 2020-09-14 15:01 UTC (permalink / raw)
To: sagi
Cc: minwoo.im.dev, kbusch, axboe, hch, linux-nvme, linux-kernel,
paul, jeho, Necip Fazil Yildiran
When NVME_TCP is enabled and CRYPTO is disabled, it results in the
following Kbuild warning:
WARNING: unmet direct dependencies detected for CRYPTO_CRC32C
Depends on [n]: CRYPTO [=n]
Selected by [y]:
- NVME_TCP [=y] && INET [=y] && BLK_DEV_NVME [=y]
The reason is that NVME_TCP selects CRYPTO_CRC32C without depending on or
selecting CRYPTO while CRYPTO_CRC32C is subordinate to CRYPTO.
Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
Fixes: 79fd751d61aa ("nvme: tcp: selects CRYPTO_CRC32C for nvme-tcp")
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
---
drivers/nvme/host/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
index 3ed9786b88d8..a44d49d63968 100644
--- a/drivers/nvme/host/Kconfig
+++ b/drivers/nvme/host/Kconfig
@@ -73,6 +73,7 @@ config NVME_TCP
depends on INET
depends on BLK_DEV_NVME
select NVME_FABRICS
+ select CRYPTO
select CRYPTO_CRC32C
help
This provides support for the NVMe over Fabrics protocol using
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: tcp: fix kconfig dependency warning when !CRYPTO
2020-09-14 15:01 [PATCH] nvme: tcp: fix kconfig dependency warning when !CRYPTO Necip Fazil Yildiran
@ 2020-09-14 19:24 ` Sagi Grimberg
2020-09-15 5:59 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2020-09-14 19:24 UTC (permalink / raw)
To: Necip Fazil Yildiran
Cc: minwoo.im.dev, kbusch, axboe, hch, linux-nvme, linux-kernel, paul, jeho
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvme: tcp: fix kconfig dependency warning when !CRYPTO
2020-09-14 15:01 [PATCH] nvme: tcp: fix kconfig dependency warning when !CRYPTO Necip Fazil Yildiran
2020-09-14 19:24 ` Sagi Grimberg
@ 2020-09-15 5:59 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-09-15 5:59 UTC (permalink / raw)
To: Necip Fazil Yildiran
Cc: sagi, minwoo.im.dev, kbusch, axboe, hch, linux-nvme,
linux-kernel, paul, jeho
Thanks,
applied to nvme-5.9.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-15 5:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-14 15:01 [PATCH] nvme: tcp: fix kconfig dependency warning when !CRYPTO Necip Fazil Yildiran
2020-09-14 19:24 ` Sagi Grimberg
2020-09-15 5:59 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®