mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Brauner <christian.brauner@ubuntu.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: akpm@linux-foundation.org, peterz@infradead.org,
	mingo@kernel.org, ebiederm@xmission.com, christian@kellner.me,
	surenb@google.com, areber@redhat.com, shakeelb@google.com,
	cyphar@cyphar.com, tglx@linutronix.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fork: Use helper function mapping_allow_writable() in dup_mmap()
Date: Tue, 15 Sep 2020 17:47:04 +0200	[thread overview]
Message-ID: <20200915154704.lvboxqqgfokbhidc@wittgenstein> (raw)
In-Reply-To: <20200913092415.24408-1-linmiaohe@huawei.com>

On Sun, Sep 13, 2020 at 05:24:15AM -0400, Miaohe Lin wrote:
> Use helper function mapping_allow_writable() to atomic_inc i_mmap_writable.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---

Hey Miaohe,

Thanks for the patch!
Per se there's nothing against using a proper helper when it exists.
But it has already been pointed out that this needs a proper commit
message with more rationale. But I'm otherwise happy to take this.

Thanks!
Christian

  parent reply	other threads:[~2020-09-15 16:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-13  9:24 Miaohe Lin
2020-09-13 16:18 ` Eric W. Biederman
2020-09-15 15:47 ` Christian Brauner [this message]
2020-09-14  1:38 linmiaohe
2020-09-14 12:03 ` Eric W. Biederman
2020-09-15  9:25 linmiaohe
2020-09-16  1:39 linmiaohe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200915154704.lvboxqqgfokbhidc@wittgenstein \
    --to=christian.brauner@ubuntu.com \
    --cc=akpm@linux-foundation.org \
    --cc=areber@redhat.com \
    --cc=christian@kellner.me \
    --cc=cyphar@cyphar.com \
    --cc=ebiederm@xmission.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=shakeelb@google.com \
    --cc=surenb@google.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®