From: David Miller <davem@davemloft.net>
To: zhengyongjun3@huawei.com
Cc: fmanlunas@marvell.com, sburla@marvell.com, dchickles@marvell.com,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: ethernet: Remove set but not used variable
Date: Fri, 18 Sep 2020 14:30:13 -0700 (PDT) [thread overview]
Message-ID: <20200918.143013.184259371965563025.davem@davemloft.net> (raw)
In-Reply-To: <20200918083938.21046-1-zhengyongjun3@huawei.com>
From: Zheng Yongjun <zhengyongjun3@huawei.com>
Date: Fri, 18 Sep 2020 16:39:38 +0800
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/cavium/liquidio/octeon_device.c: In function lio_pci_readq:
> drivers/net/ethernet/cavium/liquidio/octeon_device.c:1327:6: warning: variable ‘val32’ set but not used [-Wunused-but-set-variable]
>
> drivers/net/ethernet/cavium/liquidio/octeon_device.c: In function lio_pci_writeq:
> drivers/net/ethernet/cavium/liquidio/octeon_device.c:1358:6: warning: variable ‘val32’ set but not used [-Wunused-but-set-variable]
>
> these variable is never used, so remove it.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
The proper subsystem prefix for these changes is just "liquidio: ".
For changes to a specific driver it is not appropriate to use
"net: ethernet: " or similar.
Please fix up your Subject line and resubmit.
Thank you.
next prev parent reply other threads:[~2020-09-18 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 8:39 Zheng Yongjun
2020-09-18 21:30 ` David Miller [this message]
2020-09-19 1:31 ` 答复: " zhengyongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918.143013.184259371965563025.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dchickles@marvell.com \
--cc=fmanlunas@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sburla@marvell.com \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®