mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zhengyongjun <zhengyongjun3@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: "fmanlunas@marvell.com" <fmanlunas@marvell.com>,
	"sburla@marvell.com" <sburla@marvell.com>,
	"dchickles@marvell.com" <dchickles@marvell.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 答复: [PATCH net-next] net: ethernet: Remove set but not used variable
Date: Sat, 19 Sep 2020 01:31:38 +0000	[thread overview]
Message-ID: <7adfc7d14e2a4284a0b99f428d2836b0@huawei.com> (raw)
In-Reply-To: <20200918.143013.184259371965563025.davem@davemloft.net>

I have fix it and send back the patch to you. Thank you very much.

-----邮件原件-----
发件人: David Miller [mailto:davem@davemloft.net] 
发送时间: 2020年9月19日 5:30
收件人: zhengyongjun <zhengyongjun3@huawei.com>
抄送: fmanlunas@marvell.com; sburla@marvell.com; dchickles@marvell.com; kuba@kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH net-next] net: ethernet: Remove set but not used variable

From: Zheng Yongjun <zhengyongjun3@huawei.com>
Date: Fri, 18 Sep 2020 16:39:38 +0800

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/cavium/liquidio/octeon_device.c: In function lio_pci_readq:
> drivers/net/ethernet/cavium/liquidio/octeon_device.c:1327:6: warning: variable ʽval32ʼ set but not used [-Wunused-but-set-variable]
> 
> drivers/net/ethernet/cavium/liquidio/octeon_device.c: In function lio_pci_writeq:
> drivers/net/ethernet/cavium/liquidio/octeon_device.c:1358:6: warning: variable ʽval32ʼ set but not used [-Wunused-but-set-variable]
> 
> these variable is never used, so remove it.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>

The proper subsystem prefix for these changes is just "liquidio: ".

For changes to a specific driver it is not appropriate to use
"net: ethernet: " or similar.

Please fix up your Subject line and resubmit.

Thank you.

      reply	other threads:[~2020-09-19  1:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18  8:39 Zheng Yongjun
2020-09-18 21:30 ` David Miller
2020-09-19  1:31   ` zhengyongjun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7adfc7d14e2a4284a0b99f428d2836b0@huawei.com \
    --to=zhengyongjun3@huawei.com \
    --cc=davem@davemloft.net \
    --cc=dchickles@marvell.com \
    --cc=fmanlunas@marvell.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sburla@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome