From: Zhen Lei <thunder.leizhen@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>,
"Alexey Brodkin" <abrodkin@synopsys.com>,
Vineet Gupta <vgupta@synopsys.com>,
devicetree <devicetree@vger.kernel.org>,
linux-snps-arc <linux-snps-arc@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Haoyu Lv <lvhaoyu@huawei.com>, Libin <huawei.libin@huawei.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH v5 0/6] irqchip: dw-apb-ictl: support hierarchy irq domain
Date: Fri, 18 Sep 2020 19:21:56 +0800 [thread overview]
Message-ID: <20200918112202.3418-1-thunder.leizhen@huawei.com> (raw)
v4 --> v5:
1. Add WARN_ON(1) in set_handle_irq() if !GENERIC_IRQ_MULTI_HANDLER
2. Convert "snps,dw-apb-ictl.txt" to "snps,dw-apb-ictl.yaml"
3. Fix the errors detected by "snps,dw-apb-ictl.yaml" on arch/arc
v3 --> v4:
1. remove "gc->chip_types[0].chip.irq_eoi = irq_gc_noop;", the "chip.irq_eoi" hook
is not needed by handle_level_irq(). Thanks for Marc Zyngier's review.
2. Add a new patch: define an empty function set_handle_irq() if !GENERIC_IRQ_MULTI_HANDLER
to avoid compilation error on arch/arc system.
v2 --> v3:
1. change (1 << hwirq) to BIT(hwirq).
2. change __exception_irq_entry to __irq_entry, so we can "#include <linux/interrupt.h>"
instead of "#include <asm/exception.h>". Ohterwise, an compilation error will be
reported on arch/csky.
drivers/irqchip/irq-dw-apb-ictl.c:20:10: fatal error: asm/exception.h: No such file or directory
3. use "if (!parent || (np == parent))" to determine whether it is primary interrupt controller.
4. make the primary interrupt controller case also use function handle_level_irq(), I used
handle_fasteoi_irq() as flow_handler before.
5. Other minor changes are not detailed.
v1 --> v2:
According to Marc Zyngier's suggestion, discard adding an independent SD5203-VIC
driver, but make the dw-apb-ictl irqchip driver to support hierarchy irq domain.
It was originally available only for secondary interrupt controller, now it can
also be used as primary interrupt controller. The related dt-bindings is updated
appropriately.
Add "Suggested-by: Marc Zyngier <maz@kernel.org>".
Add "Tested-by: Haoyu Lv <lvhaoyu@huawei.com>".
v1:
The interrupt controller of SD5203 SoC is VIC(vector interrupt controller), it's
based on Synopsys DesignWare APB interrupt controller (dw_apb_ictl) IP, but it
can not directly use dw_apb_ictl driver. The main reason is that VIC is used as
primary interrupt controller and dw_apb_ictl driver worked for secondary
interrupt controller. So add a new driver: "hisilicon,sd5203-vic".
Zhen Lei (6):
genirq: define an empty function set_handle_irq() if
!GENERIC_IRQ_MULTI_HANDLER
irqchip: dw-apb-ictl: prepare for support hierarchy irq domain
irqchip: dw-apb-ictl: support hierarchy irq domain
dt-bindings: dw-apb-ictl: support hierarchy irq domain
dt-bindings: dw-apb-ictl: convert to json-schema
ARC: [dts] fix the errors detected by dtbs_check
.../interrupt-controller/snps,dw-apb-ictl.txt | 31 --------
.../interrupt-controller/snps,dw-apb-ictl.yaml | 75 +++++++++++++++++++
arch/arc/boot/dts/axc001.dtsi | 2 +-
arch/arc/boot/dts/axc003.dtsi | 2 +-
arch/arc/boot/dts/axc003_idu.dtsi | 2 +-
arch/arc/boot/dts/vdk_axc003.dtsi | 2 +-
arch/arc/boot/dts/vdk_axc003_idu.dtsi | 2 +-
drivers/irqchip/Kconfig | 2 +-
drivers/irqchip/irq-dw-apb-ictl.c | 83 ++++++++++++++++++----
include/linux/irq.h | 6 ++
10 files changed, 158 insertions(+), 49 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/snps,dw-apb-ictl.txt
create mode 100644 Documentation/devicetree/bindings/interrupt-controller/snps,dw-apb-ictl.yaml
--
1.8.3
next reply other threads:[~2020-09-18 11:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 11:21 Zhen Lei [this message]
2020-09-18 11:21 ` [PATCH v5 1/6] genirq: define an empty function set_handle_irq() if !GENERIC_IRQ_MULTI_HANDLER Zhen Lei
2020-09-18 11:21 ` [PATCH v5 2/6] irqchip: dw-apb-ictl: prepare for support hierarchy irq domain Zhen Lei
2020-09-18 11:21 ` [PATCH v5 3/6] irqchip: dw-apb-ictl: " Zhen Lei
2020-09-18 11:22 ` [PATCH v5 4/6] dt-bindings: " Zhen Lei
2020-09-23 20:49 ` Rob Herring
2020-09-18 11:22 ` [PATCH v5 5/6] dt-bindings: dw-apb-ictl: convert to json-schema Zhen Lei
2020-09-23 20:49 ` Rob Herring
2020-09-24 3:26 ` Leizhen (ThunderTown)
2020-09-24 4:17 ` Leizhen (ThunderTown)
2020-09-18 11:22 ` [PATCH v5 6/6] ARC: [dts] fix the errors detected by dtbs_check Zhen Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918112202.3418-1-thunder.leizhen@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=abrodkin@synopsys.com \
--cc=devicetree@vger.kernel.org \
--cc=huawei.libin@huawei.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=lvhaoyu@huawei.com \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tglx@linutronix.de \
--cc=vgupta@synopsys.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®