mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] lib/crc32.c: fix trivial typo in preprocessor condition
@ 2020-09-23 18:21 Tobias Jordan
  0 siblings, 0 replies; only message in thread
From: Tobias Jordan @ 2020-09-23 18:21 UTC (permalink / raw)
  To: Andrew Morton, linux-kernel
  Cc: Krzysztof Kozlowski, Jonathan Corbet, Mauro Carvalho Chehab, Jiri Kosina

Whether crc32_be needs a lookup table is chosen based on CRC_LE_BITS.
Obviously, the _be function should be governed by the _BE_ define.

This probably never pops up as it's hard to come up with a configuration
where CRC_BE_BITS isn't the same as CRC_LE_BITS and as nobody is using
bitwise CRC anyway.

<rant>
While skimming through some mailing lists, I learned that not only is
this a safety critical bug[tm], it likely will also lead to a car crash
unless fixed[1]. We can't let that happen, can we?
As the safety experts are now for more than one month working on a patch
already, it's maybe time to save them some effort.

[1]: https://lists.elisa.tech/g/devel/message/1089
</rant>

Fixes: 46c5801eaf86 ("crc32: bolt on crc32c")
Signed-off-by: Tobias Jordan <kernel@cdqe.de>
---
Sorry for spamming people in CC:, there doesn't seem to be a designated
maintainer for lib/crc*.

 lib/crc32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/crc32.c b/lib/crc32.c
index 35a03d03f973..2a68dfd3b96c 100644
--- a/lib/crc32.c
+++ b/lib/crc32.c
@@ -331,7 +331,7 @@ static inline u32 __pure crc32_be_generic(u32 crc, unsigned char const *p,
 	return crc;
 }
 
-#if CRC_LE_BITS == 1
+#if CRC_BE_BITS == 1
 u32 __pure crc32_be(u32 crc, unsigned char const *p, size_t len)
 {
 	return crc32_be_generic(crc, p, len, NULL, CRC32_POLY_BE);
-- 
2.20.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-09-23 18:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23 18:21 [PATCH] lib/crc32.c: fix trivial typo in preprocessor condition Tobias Jordan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®