From: Andrew Lunn <andrew@lunn.ch>
To: Ivan Khoronzhuk <ivan.khoronzhuk@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
alexander.sverdlin@nokia.com, linux-kernel@vger.kernel.org,
Ivan Khoronzhuk <ikhoronz@cisco.com>
Subject: Re: [PATCH] net: ethernet: cavium: octeon_mgmt: use phy_start and phy_stop
Date: Fri, 25 Sep 2020 18:30:06 +0200 [thread overview]
Message-ID: <20200925163006.GB3856392@lunn.ch> (raw)
In-Reply-To: <20200925124439.19946-1-ikhoronz@cisco.com>
On Fri, Sep 25, 2020 at 03:44:39PM +0300, Ivan Khoronzhuk wrote:
> To start also "phy state machine", with UP state as it should be,
> the phy_start() has to be used, in another case machine even is not
> triggered. After this change negotiation is supposed to be triggered
> by SM workqueue.
>
> It's not correct usage, but it appears after the following patch,
> so add it as a fix.
>
> Fixes: 74a992b3598a ("net: phy: add phy_check_link_status")
> Signed-off-by: Ivan Khoronzhuk <ikhoronz@cisco.com>
> ---
>
> Based on net/master
Hi Ivan
In the future, please make the patch subject [PATCH net] to make it
clear which tree it is for.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-09-25 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 12:44 Ivan Khoronzhuk
2020-09-25 16:30 ` Andrew Lunn [this message]
2020-09-25 23:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925163006.GB3856392@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexander.sverdlin@nokia.com \
--cc=davem@davemloft.net \
--cc=ikhoronz@cisco.com \
--cc=ivan.khoronzhuk@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®