* [PATCH v3] leds: tlc591xx: fix leak of device node iterator
@ 2020-09-26 16:27 Tobias Jordan
2020-09-29 6:56 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Jordan @ 2020-09-26 16:27 UTC (permalink / raw)
To: linux-leds, linux-kernel
Cc: Pavel Machek, Dan Murphy, Tomi Valkeinen, Marek Behún,
Markus Elfring
In one of the error paths of the for_each_child_of_node loop in
tlc591xx_probe, add missing call to of_node_put.
Fixes: 1ab4531ad132 ("leds: tlc591xx: simplify driver by using the managed led API")
Signed-off-by: Tobias Jordan <kernel@cdqe.de>
Reviewed-by: Marek Behún <kabel@kernel.org>
---
v3: removed linebreak from Fixes: tag in commit message
v2: rebased to Pavel's for-next branch
drivers/leds/leds-tlc591xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c
index 0929f1275814..a8cc49752cd5 100644
--- a/drivers/leds/leds-tlc591xx.c
+++ b/drivers/leds/leds-tlc591xx.c
@@ -214,6 +214,7 @@ tlc591xx_probe(struct i2c_client *client,
err = devm_led_classdev_register_ext(dev, &led->ldev,
&init_data);
if (err < 0) {
+ of_node_put(child);
if (err != -EPROBE_DEFER)
dev_err(dev, "couldn't register LED %s\n",
led->ldev.name);
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v3] leds: tlc591xx: fix leak of device node iterator
2020-09-26 16:27 [PATCH v3] leds: tlc591xx: fix leak of device node iterator Tobias Jordan
@ 2020-09-29 6:56 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2020-09-29 6:56 UTC (permalink / raw)
To: Tobias Jordan, linux-leds, linux-kernel
Cc: Pavel Machek, Dan Murphy, Marek Behún, Markus Elfring
On 26/09/2020 19:27, Tobias Jordan wrote:
> In one of the error paths of the for_each_child_of_node loop in
> tlc591xx_probe, add missing call to of_node_put.
>
> Fixes: 1ab4531ad132 ("leds: tlc591xx: simplify driver by using the managed led API")
> Signed-off-by: Tobias Jordan <kernel@cdqe.de>
> Reviewed-by: Marek Behún <kabel@kernel.org>
>
> ---
> v3: removed linebreak from Fixes: tag in commit message
> v2: rebased to Pavel's for-next branch
>
> drivers/leds/leds-tlc591xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c
> index 0929f1275814..a8cc49752cd5 100644
> --- a/drivers/leds/leds-tlc591xx.c
> +++ b/drivers/leds/leds-tlc591xx.c
> @@ -214,6 +214,7 @@ tlc591xx_probe(struct i2c_client *client,
> err = devm_led_classdev_register_ext(dev, &led->ldev,
> &init_data);
> if (err < 0) {
> + of_node_put(child);
> if (err != -EPROBE_DEFER)
> dev_err(dev, "couldn't register LED %s\n",
> led->ldev.name);
>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-29 6:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-26 16:27 [PATCH v3] leds: tlc591xx: fix leak of device node iterator Tobias Jordan
2020-09-29 6:56 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®