* [PATCH] locking/seqlock: Tweak DEFINE_SEQLOCK() kernel doc
@ 2020-09-24 15:48 Sebastian Andrzej Siewior
2020-10-06 12:30 ` Sebastian Andrzej Siewior
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Sebastian Andrzej Siewior @ 2020-09-24 15:48 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Zijlstra, Ingo Molnar, Will Deacon, Thomas Gleixner
ctags creates a warning:
|ctags: Warning: include/linux/seqlock.h:738: null expansion of name pattern "\2"
The DEFINE_SEQLOCK() macro is passed to ctags and being told to expect
an argument.
Add a dummy argument to keep ctags quiet.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
include/linux/seqlock.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
index 962d9768945f0..4a69e74dc7ce9 100644
--- a/include/linux/seqlock.h
+++ b/include/linux/seqlock.h
@@ -735,7 +735,7 @@ typedef struct {
} while (0)
/**
- * DEFINE_SEQLOCK() - Define a statically allocated seqlock_t
+ * DEFINE_SEQLOCK(sl) - Define a statically allocated seqlock_t
* @sl: Name of the seqlock_t instance
*/
#define DEFINE_SEQLOCK(sl) \
--
2.28.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] locking/seqlock: Tweak DEFINE_SEQLOCK() kernel doc
2020-09-24 15:48 [PATCH] locking/seqlock: Tweak DEFINE_SEQLOCK() kernel doc Sebastian Andrzej Siewior
@ 2020-10-06 12:30 ` Sebastian Andrzej Siewior
2020-10-06 12:41 ` Will Deacon
2020-10-07 16:20 ` [tip: locking/core] " tip-bot2 for Sebastian Andrzej Siewior
2 siblings, 0 replies; 5+ messages in thread
From: Sebastian Andrzej Siewior @ 2020-10-06 12:30 UTC (permalink / raw)
To: linux-kernel; +Cc: Peter Zijlstra, Ingo Molnar, Will Deacon, Thomas Gleixner
On 2020-09-24 17:48:53 [+0200], To linux-kernel@vger.kernel.org wrote:
> ctags creates a warning:
> |ctags: Warning: include/linux/seqlock.h:738: null expansion of name pattern "\2"
>
> The DEFINE_SEQLOCK() macro is passed to ctags and being told to expect
> an argument.
>
> Add a dummy argument to keep ctags quiet.
ping.
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> include/linux/seqlock.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
> index 962d9768945f0..4a69e74dc7ce9 100644
> --- a/include/linux/seqlock.h
> +++ b/include/linux/seqlock.h
> @@ -735,7 +735,7 @@ typedef struct {
> } while (0)
>
> /**
> - * DEFINE_SEQLOCK() - Define a statically allocated seqlock_t
> + * DEFINE_SEQLOCK(sl) - Define a statically allocated seqlock_t
> * @sl: Name of the seqlock_t instance
> */
> #define DEFINE_SEQLOCK(sl) \
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] locking/seqlock: Tweak DEFINE_SEQLOCK() kernel doc
2020-09-24 15:48 [PATCH] locking/seqlock: Tweak DEFINE_SEQLOCK() kernel doc Sebastian Andrzej Siewior
2020-10-06 12:30 ` Sebastian Andrzej Siewior
@ 2020-10-06 12:41 ` Will Deacon
2020-10-06 13:17 ` Peter Zijlstra
2020-10-07 16:20 ` [tip: locking/core] " tip-bot2 for Sebastian Andrzej Siewior
2 siblings, 1 reply; 5+ messages in thread
From: Will Deacon @ 2020-10-06 12:41 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: linux-kernel, Peter Zijlstra, Ingo Molnar, Thomas Gleixner
On Thu, Sep 24, 2020 at 05:48:51PM +0200, Sebastian Andrzej Siewior wrote:
> ctags creates a warning:
> |ctags: Warning: include/linux/seqlock.h:738: null expansion of name pattern "\2"
>
> The DEFINE_SEQLOCK() macro is passed to ctags and being told to expect
> an argument.
>
> Add a dummy argument to keep ctags quiet.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> include/linux/seqlock.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
> index 962d9768945f0..4a69e74dc7ce9 100644
> --- a/include/linux/seqlock.h
> +++ b/include/linux/seqlock.h
> @@ -735,7 +735,7 @@ typedef struct {
> } while (0)
>
> /**
> - * DEFINE_SEQLOCK() - Define a statically allocated seqlock_t
> + * DEFINE_SEQLOCK(sl) - Define a statically allocated seqlock_t
> * @sl: Name of the seqlock_t instance
> */
> #define DEFINE_SEQLOCK(sl) \
Acked-by: Will Deacon <will@kernel.org>
Will
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] locking/seqlock: Tweak DEFINE_SEQLOCK() kernel doc
2020-10-06 12:41 ` Will Deacon
@ 2020-10-06 13:17 ` Peter Zijlstra
0 siblings, 0 replies; 5+ messages in thread
From: Peter Zijlstra @ 2020-10-06 13:17 UTC (permalink / raw)
To: Will Deacon
Cc: Sebastian Andrzej Siewior, linux-kernel, Ingo Molnar, Thomas Gleixner
On Tue, Oct 06, 2020 at 01:41:47PM +0100, Will Deacon wrote:
> On Thu, Sep 24, 2020 at 05:48:51PM +0200, Sebastian Andrzej Siewior wrote:
> > ctags creates a warning:
> > |ctags: Warning: include/linux/seqlock.h:738: null expansion of name pattern "\2"
> >
> > The DEFINE_SEQLOCK() macro is passed to ctags and being told to expect
> > an argument.
> >
> > Add a dummy argument to keep ctags quiet.
> >
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> > include/linux/seqlock.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
> > index 962d9768945f0..4a69e74dc7ce9 100644
> > --- a/include/linux/seqlock.h
> > +++ b/include/linux/seqlock.h
> > @@ -735,7 +735,7 @@ typedef struct {
> > } while (0)
> >
> > /**
> > - * DEFINE_SEQLOCK() - Define a statically allocated seqlock_t
> > + * DEFINE_SEQLOCK(sl) - Define a statically allocated seqlock_t
> > * @sl: Name of the seqlock_t instance
> > */
> > #define DEFINE_SEQLOCK(sl) \
>
> Acked-by: Will Deacon <will@kernel.org>
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip: locking/core] locking/seqlock: Tweak DEFINE_SEQLOCK() kernel doc
2020-09-24 15:48 [PATCH] locking/seqlock: Tweak DEFINE_SEQLOCK() kernel doc Sebastian Andrzej Siewior
2020-10-06 12:30 ` Sebastian Andrzej Siewior
2020-10-06 12:41 ` Will Deacon
@ 2020-10-07 16:20 ` tip-bot2 for Sebastian Andrzej Siewior
2 siblings, 0 replies; 5+ messages in thread
From: tip-bot2 for Sebastian Andrzej Siewior @ 2020-10-07 16:20 UTC (permalink / raw)
To: linux-tip-commits
Cc: Sebastian Andrzej Siewior, Peter Zijlstra (Intel),
Will Deacon, x86, LKML
The following commit has been merged into the locking/core branch of tip:
Commit-ID: 24a1877286822293684ef3f7bada4ea48a6e129e
Gitweb: https://git.kernel.org/tip/24a1877286822293684ef3f7bada4ea48a6e129e
Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
AuthorDate: Thu, 24 Sep 2020 17:48:51 +02:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Wed, 07 Oct 2020 18:14:14 +02:00
locking/seqlock: Tweak DEFINE_SEQLOCK() kernel doc
ctags creates a warning:
|ctags: Warning: include/linux/seqlock.h:738: null expansion of name pattern "\2"
The DEFINE_SEQLOCK() macro is passed to ctags and being told to expect
an argument.
Add a dummy argument to keep ctags quiet.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Will Deacon <will@kernel.org>
Link: https://lkml.kernel.org/r/20200924154851.skmswuyj322yuz4g@linutronix.de
---
include/linux/seqlock.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
index 76e44e6..ac5b07f 100644
--- a/include/linux/seqlock.h
+++ b/include/linux/seqlock.h
@@ -821,7 +821,7 @@ typedef struct {
} while (0)
/**
- * DEFINE_SEQLOCK() - Define a statically allocated seqlock_t
+ * DEFINE_SEQLOCK(sl) - Define a statically allocated seqlock_t
* @sl: Name of the seqlock_t instance
*/
#define DEFINE_SEQLOCK(sl) \
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-07 16:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-24 15:48 [PATCH] locking/seqlock: Tweak DEFINE_SEQLOCK() kernel doc Sebastian Andrzej Siewior
2020-10-06 12:30 ` Sebastian Andrzej Siewior
2020-10-06 12:41 ` Will Deacon
2020-10-06 13:17 ` Peter Zijlstra
2020-10-07 16:20 ` [tip: locking/core] " tip-bot2 for Sebastian Andrzej Siewior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®