* linux-next: Fixes tag needs some work in the gpio tree
@ 2020-10-07 20:52 Stephen Rothwell
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2020-10-07 20:52 UTC (permalink / raw)
To: Linus Walleij
Cc: Mauro Carvalho Chehab, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
Hi all,
In commit
62ba77749ead ("docs: gpio: add a new document to its index.rst")
Fixes tag
Fixes: fd1abe99e5fb ("Documentation: gpio: add documentation for gpio-mockup")
has these problem(s):
- Target SHA1 does not exist
Maybe you ment
Fixes: 2fd1abe99e5f ("Documentation: gpio: add documentation for gpio-mockup")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* linux-next: Fixes tag needs some work in the gpio tree
@ 2020-03-21 5:27 Stephen Rothwell
2020-03-21 15:09 ` Hans de Goede
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2020-03-21 5:27 UTC (permalink / raw)
To: Linus Walleij
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Hans de Goede
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
Hi all,
In commit
1b26f3ba6117 ("gpiolib: acpi: Add quirk to ignore EC wakeups on HP x2 10 CHT + AXP288 model")
Fixes tag
Fixes: aa23ca3d98f7 ("gpiolib: acpi: Add honor_wakeup module-option + quirk mech
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please do not truncate the commit subject in Fixes tags.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: Fixes tag needs some work in the gpio tree
2020-03-21 5:27 Stephen Rothwell
@ 2020-03-21 15:09 ` Hans de Goede
2020-03-24 9:08 ` Linus Walleij
0 siblings, 1 reply; 4+ messages in thread
From: Hans de Goede @ 2020-03-21 15:09 UTC (permalink / raw)
To: Stephen Rothwell, Linus Walleij
Cc: Linux Next Mailing List, Linux Kernel Mailing List
Hi,
On 3/21/20 6:27 AM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 1b26f3ba6117 ("gpiolib: acpi: Add quirk to ignore EC wakeups on HP x2 10 CHT + AXP288 model")
>
> Fixes tag
>
> Fixes: aa23ca3d98f7 ("gpiolib: acpi: Add honor_wakeup module-option + quirk mech
I see in my personal tree that I introduced this broken tag, sorry about
that. Linus, if you are ok with doing a forced push to fix it up then
the correct tag should be:
Fixes: aa23ca3d98f7 ("gpiolib: acpi: Add honor_wakeup module-option + quirk mechanism")
OTOH if you dislike forced pushes (which I completely understand)
then we will just have to live with the broken tag.
Regards,
Hans
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: Fixes tag needs some work in the gpio tree
2020-03-21 15:09 ` Hans de Goede
@ 2020-03-24 9:08 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2020-03-24 9:08 UTC (permalink / raw)
To: Hans de Goede
Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List
On Sat, Mar 21, 2020 at 4:09 PM Hans de Goede <hdegoede@redhat.com> wrote:
> On 3/21/20 6:27 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > 1b26f3ba6117 ("gpiolib: acpi: Add quirk to ignore EC wakeups on HP x2 10 CHT + AXP288 model")
> >
> > Fixes tag
> >
> > Fixes: aa23ca3d98f7 ("gpiolib: acpi: Add honor_wakeup module-option + quirk mech
>
> I see in my personal tree that I introduced this broken tag, sorry about
> that. Linus, if you are ok with doing a forced push to fix it up then
> the correct tag should be:
>
> Fixes: aa23ca3d98f7 ("gpiolib: acpi: Add honor_wakeup module-option + quirk mechanism")
>
> OTOH if you dislike forced pushes (which I completely understand)
> then we will just have to live with the broken tag.
I fixed it up! Actually I don't dislike rebasing patches on the fixes
branch at all.
The devel branch (for next) is much more sensitive.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-07 20:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-07 20:52 linux-next: Fixes tag needs some work in the gpio tree Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2020-03-21 5:27 Stephen Rothwell
2020-03-21 15:09 ` Hans de Goede
2020-03-24 9:08 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®