mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: remove unneeded semicolon
@ 2020-10-27 20:07 trix
  2020-10-30  3:36 ` Alex Deucher
  0 siblings, 1 reply; 5+ messages in thread
From: trix @ 2020-10-27 20:07 UTC (permalink / raw)
  To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
	airlied, daniel, Rodrigo.Siqueira, Anthony.Koo, Aric.Cyr,
	Tony.Cheng, Igor.Kravchenko, Charlene.Liu, colin.king,
	Wenjing.Liu, joseph.gravenor, Bhawanpreet.Lakha
  Cc: amd-gfx, dri-devel, linux-kernel, Tom Rix

From: Tom Rix <trix@redhat.com>

A semicolon is not needed after a switch statement.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +-
 drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
index 7b4b2304bbff..5feb804af4be 100644
--- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
@@ -858,7 +858,7 @@ static struct clock_source *find_matching_pll(
 		return pool->clock_sources[DCE112_CLK_SRC_PLL5];
 	default:
 		return NULL;
-	};
+	}
 
 	return 0;
 }
diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c
index fb6a19d020f9..ee5230ccf3c4 100644
--- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c
+++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c
@@ -280,6 +280,6 @@ char *mod_hdcp_state_id_to_str(int32_t id)
 		return "D2_A9_VALIDATE_STREAM_READY";
 	default:
 		return "UNKNOWN_STATE_ID";
-	};
+	}
 }
 
-- 
2.18.1


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/display: remove unneeded semicolon
  2020-10-27 20:07 [PATCH] drm/amd/display: remove unneeded semicolon trix
@ 2020-10-30  3:36 ` Alex Deucher
  0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2020-10-30  3:36 UTC (permalink / raw)
  To: trix
  Cc: Wentland, Harry, Leo (Sunpeng) Li, Deucher, Alexander,
	Christian Koenig, Dave Airlie, Daniel Vetter, Siqueira, Rodrigo,
	Anthony Koo, Cyr, Aric, Cheng, Tony, Igor.Kravchenko,
	Charlene Liu, Colin Ian King, Wenjing Liu, joseph.gravenor,
	Bhawanpreet Lakha, Maling list - DRI developers, amd-gfx list,
	LKML

Applied.  Thanks!

Alex

On Tue, Oct 27, 2020 at 4:07 PM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> A semicolon is not needed after a switch statement.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +-
>  drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c     | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> index 7b4b2304bbff..5feb804af4be 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> @@ -858,7 +858,7 @@ static struct clock_source *find_matching_pll(
>                 return pool->clock_sources[DCE112_CLK_SRC_PLL5];
>         default:
>                 return NULL;
> -       };
> +       }
>
>         return 0;
>  }
> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c
> index fb6a19d020f9..ee5230ccf3c4 100644
> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c
> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.c
> @@ -280,6 +280,6 @@ char *mod_hdcp_state_id_to_str(int32_t id)
>                 return "D2_A9_VALIDATE_STREAM_READY";
>         default:
>                 return "UNKNOWN_STATE_ID";
> -       };
> +       }
>  }
>
> --
> 2.18.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/display: remove unneeded semicolon
  2024-09-12  1:48 Yu Liao
@ 2024-09-12 17:44 ` Alex Deucher
  0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2024-09-12 17:44 UTC (permalink / raw)
  To: Yu Liao
  Cc: alexander.deucher, xiexiuqi, linux-kernel, amd-gfx, sunpeng.li,
	harry.wentland

On Thu, Sep 12, 2024 at 3:12 AM Yu Liao <liaoyu15@huawei.com> wrote:
>
> Remove unneeded semicolon.
>
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>

Thanks for the patch.  This was already fixed.

Alex

> ---
>  drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c
> index 92238ff333a4..7595355281c2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c
> @@ -421,7 +421,7 @@ unsigned int dml2_calc_max_scaled_time(
>
>  void dml2_extract_writeback_wm(struct dc_state *context, struct display_mode_lib_st *dml_core_ctx)
>  {
> -       int i, j = 0;;
> +       int i, j = 0;
>         struct mcif_arb_params *wb_arb_params = NULL;
>         struct dcn_bw_writeback *bw_writeback = NULL;
>         enum mmhubbub_wbif_mode wbif_mode = PACKED_444_FP16; /*for now*/
> --
> 2.33.0
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] drm/amd/display: remove unneeded semicolon
@ 2024-09-12  1:48 Yu Liao
  2024-09-12 17:44 ` Alex Deucher
  0 siblings, 1 reply; 5+ messages in thread
From: Yu Liao @ 2024-09-12  1:48 UTC (permalink / raw)
  To: alexander.deucher
  Cc: liaoyu15, xiexiuqi, linux-kernel, amd-gfx, sunpeng.li, harry.wentland

Remove unneeded semicolon.

Signed-off-by: Yu Liao <liaoyu15@huawei.com>
---
 drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c
index 92238ff333a4..7595355281c2 100644
--- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c
+++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c
@@ -421,7 +421,7 @@ unsigned int dml2_calc_max_scaled_time(
 
 void dml2_extract_writeback_wm(struct dc_state *context, struct display_mode_lib_st *dml_core_ctx)
 {
-	int i, j = 0;;
+	int i, j = 0;
 	struct mcif_arb_params *wb_arb_params = NULL;
 	struct dcn_bw_writeback *bw_writeback = NULL;
 	enum mmhubbub_wbif_mode wbif_mode = PACKED_444_FP16; /*for now*/
-- 
2.33.0


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/display: remove unneeded semicolon
  2024-08-02  2:59 [PATCH -next] " Jiapeng Chong
@ 2024-08-02 16:54 ` David Tadokoro
  0 siblings, 0 replies; 5+ messages in thread
From: David Tadokoro @ 2024-08-02 16:54 UTC (permalink / raw)
  To: jiapeng.chong
  Cc: Rodrigo.Siqueira, Xinhui.Pan, abaci, airlied, alexander.deucher,
	amd-gfx, chaitanya.dhere, christian.koenig, daniel, dri-devel,
	harry.wentland, jun.lei, linux-kernel, sunpeng.li

> No functional modification involved.
> 
> ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c:6463:166-167: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9633
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  .../display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c    | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c
> index c54c29711a65..8f3c1c0b1cc1 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c
> @@ -6464,8 +6464,8 @@ static void CalculateSwathAndDETConfiguration(struct dml2_core_internal_scratch
>  			p->SwathHeightC[k] = l->MaximumSwathHeightC[k] / 2;
>  			l->RoundedUpSwathSizeBytesY[k] = p->full_swath_bytes_l[k] / 2;
>  			l->RoundedUpSwathSizeBytesC[k] = p->full_swath_bytes_c[k] / 2;
> -			p->request_size_bytes_luma[k] = ((p->BytePerPixY[k] == 2) == dml_is_vertical_rotation(p->display_cfg->plane_descriptors[k].composition.rotation_angle)) ? 128 : 64;;
> -			p->request_size_bytes_chroma[k] = ((p->BytePerPixC[k] == 2) == dml_is_vertical_rotation(p->display_cfg->plane_descriptors[k].composition.rotation_angle)) ? 128 : 64;;
> +			p->request_size_bytes_luma[k] = ((p->BytePerPixY[k] == 2) == dml_is_vertical_rotation(p->display_cfg->plane_descriptors[k].composition.rotation_angle)) ? 128 : 64;
> +			p->request_size_bytes_chroma[k] = ((p->BytePerPixC[k] == 2) == dml_is_vertical_rotation(p->display_cfg->plane_descriptors[k].composition.rotation_angle)) ? 128 : 64;
>  		}
>  
>  		if (p->SwathHeightC[k] == 0)
> -- 
> 2.32.0.3.g01195cf9f

Reviewed-by: David Tadokoro <davidbtadokoro@usp.br>

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-12 17:44 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 20:07 [PATCH] drm/amd/display: remove unneeded semicolon trix
2020-10-30  3:36 ` Alex Deucher
2024-08-02  2:59 [PATCH -next] " Jiapeng Chong
2024-08-02 16:54 ` [PATCH] " David Tadokoro
2024-09-12  1:48 Yu Liao
2024-09-12 17:44 ` Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®