From: "John B. Wyatt IV" <jbwyatt4@gmail.com>
To: "' Joel Fernandes (Google)" <joel@joelfernandes.org>,
Nishanth Aravamudan <naravamudan@digitalocean.com>,
Julien Desfossez <jdesfossez@digitalocean.com>,
Peter Zijlstra <peterz@infradead.org>,
Tim Chen <tim.c.chen@linux.intel.com>,
Vineeth Pillai <viremana@linux.microsoft.com>,
Aaron Lu <aaron.lwe@gmail.com>,
Aubrey Li <aubrey.intel@gmail.com>,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
mingo@kernel.org, torvalds@linux-foundation.org,
fweisbec@gmail.com, keescook@chromium.org, kerrnel@google.com,
Phil Auld <pauld@redhat.com>,
Valentin Schneider <valentin.schneider@arm.com>,
Mel Gorman <mgorman@techsingularity.net>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
vineeth@bitbyteword.org, Chen Yu <yu.c.chen@intel.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Agata Gruza <agata.gruza@intel.com>,
Antonio Gomez Iglesias <antonio.gomez.iglesias@intel.com>,
graf@amazon.com, konrad.wilk@oracle.com, dfaggioli@suse.com,
pjt@google.com, rostedt@goodmis.org, derkling@google.com,
benbjiang@tencent.com,
Alexandre Chartre <alexandre.chartre@oracle.com>,
James.Bottomley@hansenpartnership.com, OWeisse@umich.edu,
Dhaval Giani <dhaval.giani@oracle.com>,
Junaid Shahid <junaids@google.com>,
jsbarnes@google.com, chris.hyser@oracle.com,
Aubrey Li <aubrey.li@linux.intel.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Tim Chen ' <tim.c.chen@intel.com>
Cc: "John B. Wyatt IV" <jbwyatt4@gmail.com>
Subject: [PATCH 3/8] sched: Fix some style issues in test_coresched.c
Date: Wed, 28 Oct 2020 05:19:12 -0700 [thread overview]
Message-ID: <20201028121917.635203-4-jbwyatt4@gmail.com> (raw)
In-Reply-To: <20201028121917.635203-1-jbwyatt4@gmail.com>
Line 825: open brace '{' following function definitions go
on the next line.
Line 459: that open brace { should be on the previous line
Line 459: space required before the open parenthesis '('
Issues reported by checkpatch.
There are other issues including over a hundred instances of using spaces
instead of tabs in this file.
I am currently fixing these specific issues in this patch.
Signed-off-by: John B. Wyatt IV <jbwyatt4@gmail.com>
---
tools/testing/selftests/sched/test_coresched.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/sched/test_coresched.c b/tools/testing/selftests/sched/test_coresched.c
index 91cfb00f15b5..f11ed8370c07 100644
--- a/tools/testing/selftests/sched/test_coresched.c
+++ b/tools/testing/selftests/sched/test_coresched.c
@@ -459,9 +459,8 @@ char *get_task_core_cookie(char *pid)
sprintf(proc_path, "/proc/%s/sched", pid);
fp = fopen(proc_path, "r");
- while ((fgets(line, 1024, fp)) != NULL)
- {
- if(!strstr(line, "core_cookie"))
+ while ((fgets(line, 1024, fp)) != NULL) {
+ if (!strstr(line, "core_cookie"))
continue;
for (j = 0, i = 0; i < 1024 && line[i] != '\0'; i++)
@@ -826,7 +825,8 @@ static void test_prctl_in_group(char *root)
print_pass();
}
-int main(void) {
+int main(void)
+{
char *root = make_group(NULL, NULL);
test_cgroup_parent_tag_child_inherit(root);
--
2.28.0
next prev parent reply other threads:[~2020-10-29 2:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 12:19 [PATCH 0/8] Style and small fixes for core-scheduling John B. Wyatt IV
2020-10-28 12:19 ` [PATCH 1/8] sched: Correct misspellings in core-scheduling.rst John B. Wyatt IV
2020-10-28 12:19 ` [PATCH 2/8] sched: Fix bad function definition John B. Wyatt IV
2020-10-28 12:19 ` John B. Wyatt IV [this message]
2020-10-28 12:19 ` [PATCH 4/8] sched: Remove unused else John B. Wyatt IV
2020-10-28 12:19 ` [PATCH 5/8] sched: Add newline after declaration John B. Wyatt IV
2020-10-28 12:19 ` [PATCH 6/8] sched: Remove unneeded braces John B. Wyatt IV
2020-10-28 12:19 ` [PATCH 7/8] sched: Replace spaces with tabs John B. Wyatt IV
2020-10-28 12:19 ` [PATCH 8/8] sched: Add newlines after declarations John B. Wyatt IV
2020-10-28 14:37 ` [PATCH 0/8] Style and small fixes for core-scheduling Phil Auld
2020-10-28 18:58 ` John Wyatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028121917.635203-4-jbwyatt4@gmail.com \
--to=jbwyatt4@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=OWeisse@umich.edu \
--cc=aaron.lwe@gmail.com \
--cc=agata.gruza@intel.com \
--cc=alexandre.chartre@oracle.com \
--cc=antonio.gomez.iglesias@intel.com \
--cc=aubrey.intel@gmail.com \
--cc=aubrey.li@linux.intel.com \
--cc=benbjiang@tencent.com \
--cc=chris.hyser@oracle.com \
--cc=christian.brauner@ubuntu.com \
--cc=derkling@google.com \
--cc=dfaggioli@suse.com \
--cc=dhaval.giani@oracle.com \
--cc=fweisbec@gmail.com \
--cc=graf@amazon.com \
--cc=jdesfossez@digitalocean.com \
--cc=joel@joelfernandes.org \
--cc=jsbarnes@google.com \
--cc=junaids@google.com \
--cc=keescook@chromium.org \
--cc=kerrnel@google.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=naravamudan@digitalocean.com \
--cc=pauld@redhat.com \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@intel.com \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=valentin.schneider@arm.com \
--cc=vineeth@bitbyteword.org \
--cc=viremana@linux.microsoft.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®