From: John Wyatt <jbwyatt4@gmail.com>
To: Phil Auld <pauld@redhat.com>
Cc: "' Joel Fernandes (Google)" <joel@joelfernandes.org>,
Nishanth Aravamudan <naravamudan@digitalocean.com>,
Julien Desfossez <jdesfossez@digitalocean.com>,
Peter Zijlstra <peterz@infradead.org>,
Tim Chen <tim.c.chen@linux.intel.com>,
Vineeth Pillai <viremana@linux.microsoft.com>,
Aaron Lu <aaron.lwe@gmail.com>,
Aubrey Li <aubrey.intel@gmail.com>,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
mingo@kernel.org, torvalds@linux-foundation.org,
fweisbec@gmail.com, keescook@chromium.org, kerrnel@google.com,
Valentin Schneider <valentin.schneider@arm.com>,
Mel Gorman <mgorman@techsingularity.net>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
vineeth@bitbyteword.org, Chen Yu <yu.c.chen@intel.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Agata Gruza <agata.gruza@intel.com>,
Antonio Gomez Iglesias <antonio.gomez.iglesias@intel.com>,
graf@amazon.com, konrad.wilk@oracle.com, dfaggioli@suse.com,
pjt@google.com, rostedt@goodmis.org, derkling@google.com,
benbjiang@tencent.com,
Alexandre Chartre <alexandre.chartre@oracle.com>,
James.Bottomley@hansenpartnership.com, OWeisse@umich.edu,
Dhaval Giani <dhaval.giani@oracle.com>,
Junaid Shahid <junaids@google.com>,
jsbarnes@google.com, chris.hyser@oracle.com,
Aubrey Li <aubrey.li@linux.intel.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Tim Chen ' <tim.c.chen@intel.com>
Subject: Re: [PATCH 0/8] Style and small fixes for core-scheduling
Date: Wed, 28 Oct 2020 11:58:34 -0700 [thread overview]
Message-ID: <6de890917af3a3aa6544f5d7c892455f71964c44.camel@gmail.com> (raw)
In-Reply-To: <20201028143742.GB121779@lorien.usersys.redhat.com>
Hi Phil,
> Hi John,
>
> Welcome!
Thank you!
>
> > Please feel free to advise on any corrections or improvements that
> > can be
> > made.
>
> Thanks for these. I wonder, though, if it would not make more sense
> to post these changes as comments on the original as-yet-unmerged
> patches that you are fixing up?
Patch 23/26 has a lot of spaces to tabs issues that are isolated to one
file (and one patch if I read it correctly). It would definitely make
sense for those to be a comment. Especially with patch 23 being a later
patch in the patch series. Most of those issues are not fixed by this
patch series I submitted.
For the rest, I am willing to do resubmit as comments if that would be
easier for the submitter.
Please let me know if that is how I should resubmit them.
Being a patch set does makes them easier to verify. Some warnings
against the individual patches, like braces surrounding a one line in a
if block, disappear with later patches as the code is added. For
clarity for the mailing list, I used the jfern tree with the
'coresched-v8-posted-to-list'.
https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git/tag/?h=coresched-v8-posted-to-list
Thank you for your feedback.
--
Sincerely,
John Wyatt
prev parent reply other threads:[~2020-10-29 0:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 12:19 John B. Wyatt IV
2020-10-28 12:19 ` [PATCH 1/8] sched: Correct misspellings in core-scheduling.rst John B. Wyatt IV
2020-10-28 12:19 ` [PATCH 2/8] sched: Fix bad function definition John B. Wyatt IV
2020-10-28 12:19 ` [PATCH 3/8] sched: Fix some style issues in test_coresched.c John B. Wyatt IV
2020-10-28 12:19 ` [PATCH 4/8] sched: Remove unused else John B. Wyatt IV
2020-10-28 12:19 ` [PATCH 5/8] sched: Add newline after declaration John B. Wyatt IV
2020-10-28 12:19 ` [PATCH 6/8] sched: Remove unneeded braces John B. Wyatt IV
2020-10-28 12:19 ` [PATCH 7/8] sched: Replace spaces with tabs John B. Wyatt IV
2020-10-28 12:19 ` [PATCH 8/8] sched: Add newlines after declarations John B. Wyatt IV
2020-10-28 14:37 ` [PATCH 0/8] Style and small fixes for core-scheduling Phil Auld
2020-10-28 18:58 ` John Wyatt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6de890917af3a3aa6544f5d7c892455f71964c44.camel@gmail.com \
--to=jbwyatt4@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=OWeisse@umich.edu \
--cc=aaron.lwe@gmail.com \
--cc=agata.gruza@intel.com \
--cc=alexandre.chartre@oracle.com \
--cc=antonio.gomez.iglesias@intel.com \
--cc=aubrey.intel@gmail.com \
--cc=aubrey.li@linux.intel.com \
--cc=benbjiang@tencent.com \
--cc=chris.hyser@oracle.com \
--cc=christian.brauner@ubuntu.com \
--cc=derkling@google.com \
--cc=dfaggioli@suse.com \
--cc=dhaval.giani@oracle.com \
--cc=fweisbec@gmail.com \
--cc=graf@amazon.com \
--cc=jdesfossez@digitalocean.com \
--cc=joel@joelfernandes.org \
--cc=jsbarnes@google.com \
--cc=junaids@google.com \
--cc=keescook@chromium.org \
--cc=kerrnel@google.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=naravamudan@digitalocean.com \
--cc=pauld@redhat.com \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@intel.com \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=valentin.schneider@arm.com \
--cc=vineeth@bitbyteword.org \
--cc=viremana@linux.microsoft.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®