* [PATCH -next] usb: Make sync_all_pins static
@ 2020-10-30 9:28 Zou Wei
2020-10-30 11:18 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Zou Wei @ 2020-10-30 9:28 UTC (permalink / raw)
To: alcooperx, gregkh, f.fainelli, bcm-kernel-feedback-list
Cc: linux-usb, linux-arm-kernel, linux-kernel, Zou Wei
Fix the following sparse warning:
drivers/usb/misc/brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static?
The sync_all_pins has only call site within brcmstb-usb-pinmap.c
It should be static
Fixes: 517c4c44b323 ("usb: Add driver to allow any GPIO to be used for 7211 USB signals")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/usb/misc/brcmstb-usb-pinmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/misc/brcmstb-usb-pinmap.c b/drivers/usb/misc/brcmstb-usb-pinmap.c
index 02144c3..cc9618d 100644
--- a/drivers/usb/misc/brcmstb-usb-pinmap.c
+++ b/drivers/usb/misc/brcmstb-usb-pinmap.c
@@ -216,7 +216,7 @@ static int parse_pins(struct device *dev, struct device_node *dn,
return 0;
}
-void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata)
+static void sync_all_pins(struct brcmstb_usb_pinmap_data *pdata)
{
struct out_pin *pout;
struct in_pin *pin;
--
2.6.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] usb: Make sync_all_pins static
2020-10-30 9:28 [PATCH -next] usb: Make sync_all_pins static Zou Wei
@ 2020-10-30 11:18 ` Andy Shevchenko
2020-10-30 12:49 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2020-10-30 11:18 UTC (permalink / raw)
To: Zou Wei
Cc: Al Cooper, Greg Kroah-Hartman, Florian Fainelli,
bcm-kernel-feedback-list, USB, linux-arm Mailing List,
Linux Kernel Mailing List
On Fri, Oct 30, 2020 at 11:18 AM Zou Wei <zou_wei@huawei.com> wrote:
The title can be more precise.
> Fix the following sparse warning:
>
> drivers/usb/misc/brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static?
Do we really need to know the path?
> The sync_all_pins has only call site within brcmstb-usb-pinmap.c
sync_all_pins()
> It should be static
Missed period.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] usb: Make sync_all_pins static
2020-10-30 11:18 ` Andy Shevchenko
@ 2020-10-30 12:49 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-10-30 12:49 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Zou Wei, Al Cooper, Florian Fainelli, bcm-kernel-feedback-list,
USB, linux-arm Mailing List, Linux Kernel Mailing List
On Fri, Oct 30, 2020 at 01:18:33PM +0200, Andy Shevchenko wrote:
> On Fri, Oct 30, 2020 at 11:18 AM Zou Wei <zou_wei@huawei.com> wrote:
>
> The title can be more precise.
>
> > Fix the following sparse warning:
> >
> > drivers/usb/misc/brcmstb-usb-pinmap.c:219:6: warning: symbol 'sync_all_pins' was not declared. Should it be static?
>
> Do we really need to know the path?
That's the warning message from the tool, why complain about it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-30 12:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-30 9:28 [PATCH -next] usb: Make sync_all_pins static Zou Wei
2020-10-30 11:18 ` Andy Shevchenko
2020-10-30 12:49 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome