[PATCH] kconfig: qconf: show Qt version in the About dialog

[PATCH] kconfig: qconf: show Qt version in the About dialog

[Masahiro Yamada]

You can get the Qt version by running "pkg-config --modversion Qt5Core"
or something, but this might be useful to get the runtime Qt version
more easily. Go to the menu "Help" -> "About", then you can see it.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 scripts/kconfig/qconf.cc | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index cbe749b44b1a..d000869b787c 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -1799,10 +1799,13 @@ void ConfigMainWindow::showIntro(void)
 void ConfigMainWindow::showAbout(void)
 {
 	static const QString str = "qconf is Copyright (C) 2002 Roman Zippel <zippel@linux-m68k.org>.\n"
-		"Copyright (C) 2015 Boris Barbulovski <bbarbulovski@gmail.com>.\n\n"
-		"Bug reports and feature request can also be entered at http://bugzilla.kernel.org/\n";
+		"Copyright (C) 2015 Boris Barbulovski <bbarbulovski@gmail.com>.\n"
+		"\n"
+		"Bug reports and feature request can also be entered at http://bugzilla.kernel.org/\n"
+		"\n"
+		"Qt Version: ";
 
-	QMessageBox::information(this, "qconf", str);
+	QMessageBox::information(this, "qconf", str + qVersion());
 }
 
 void ConfigMainWindow::saveSettings(void)
-- 
2.25.1

Re: [PATCH] kconfig: qconf: show Qt version in the About dialog

[Masahiro Yamada]

On Mon, Nov 2, 2020 at 12:40 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> You can get the Qt version by running "pkg-config --modversion Qt5Core"
> or something, but this might be useful to get the runtime Qt version
> more easily. Go to the menu "Help" -> "About", then you can see it.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---

Applied to linux-kbuild.


>  scripts/kconfig/qconf.cc | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
> index cbe749b44b1a..d000869b787c 100644
> --- a/scripts/kconfig/qconf.cc
> +++ b/scripts/kconfig/qconf.cc
> @@ -1799,10 +1799,13 @@ void ConfigMainWindow::showIntro(void)
>  void ConfigMainWindow::showAbout(void)
>  {
>         static const QString str = "qconf is Copyright (C) 2002 Roman Zippel <zippel@linux-m68k.org>.\n"
> -               "Copyright (C) 2015 Boris Barbulovski <bbarbulovski@gmail.com>.\n\n"
> -               "Bug reports and feature request can also be entered at http://bugzilla.kernel.org/\n";
> +               "Copyright (C) 2015 Boris Barbulovski <bbarbulovski@gmail.com>.\n"
> +               "\n"
> +               "Bug reports and feature request can also be entered at http://bugzilla.kernel.org/\n"
> +               "\n"
> +               "Qt Version: ";
>
> -       QMessageBox::information(this, "qconf", str);
> +       QMessageBox::information(this, "qconf", str + qVersion());
>  }
>
>  void ConfigMainWindow::saveSettings(void)
> --
> 2.25.1
>


-- 
Best Regards
Masahiro Yamada