* Re: fix fs/quota/dquot.c oops error
[not found] <2a05b12f.5374.175881b20f4.Coremail.liuyingbiao1005@126.com>
@ 2020-11-02 15:04 ` Jan Kara
0 siblings, 0 replies; only message in thread
From: Jan Kara @ 2020-11-02 15:04 UTC (permalink / raw)
To: 1; +Cc: linux-kernel, jack
On Mon 02-11-20 16:38:00, 1 wrote:
> An oops error will appear if you follow the steps below:
> 1.gcc -o test test.c
> 2.sudo ./test
>
>
> The error can be found in the dmesg file , in the function of
> "dquot_add_space". Because a pointer named "dquot" is illegal , so it
> need to use functions to detect the pointer. Through the test, it is
> found that this function named "access_ok" meets the requirements.
Thanks for the patch but it is not correct. A proper fix for this syzbot
reproducer is to add more sanity checking into quota code to verify quota
file headers are not corrupted. Because these corrupted headers cause bogus
return values from get_free_blk() and possibly other quota functions which
then confuse __dquot_initialize().
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-11-02 15:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <2a05b12f.5374.175881b20f4.Coremail.liuyingbiao1005@126.com>
2020-11-02 15:04 ` fix fs/quota/dquot.c oops error Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®