* [PATCH] drm/tegra: sor: Don't warn on probe deferral
@ 2020-11-03 11:44 Jon Hunter
2020-11-03 17:06 ` Jon Hunter
0 siblings, 1 reply; 2+ messages in thread
From: Jon Hunter @ 2020-11-03 11:44 UTC (permalink / raw)
To: Thierry Reding
Cc: David Airlie, Daniel Vetter, dri-devel, linux-tegra,
linux-kernel, Jon Hunter
Deferred probe is an expected return value for tegra_output_probe().
Given that the driver deals with it properly, there's no need to output
a warning that may potentially confuse users.
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
drivers/gpu/drm/tegra/sor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index e88a17c2937f..5a232055b8cc 100644
--- a/drivers/gpu/drm/tegra/sor.c
+++ b/drivers/gpu/drm/tegra/sor.c
@@ -3765,7 +3765,7 @@ static int tegra_sor_probe(struct platform_device *pdev)
err = tegra_output_probe(&sor->output);
if (err < 0) {
- dev_err(&pdev->dev, "failed to probe output: %d\n", err);
+ dev_err_probe(&pdev->dev, "failed to probe output: %d\n", err);
return err;
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/tegra: sor: Don't warn on probe deferral
2020-11-03 11:44 [PATCH] drm/tegra: sor: Don't warn on probe deferral Jon Hunter
@ 2020-11-03 17:06 ` Jon Hunter
0 siblings, 0 replies; 2+ messages in thread
From: Jon Hunter @ 2020-11-03 17:06 UTC (permalink / raw)
To: Thierry Reding
Cc: David Airlie, Daniel Vetter, dri-devel, linux-tegra, linux-kernel
On 03/11/2020 11:44, Jon Hunter wrote:
> Deferred probe is an expected return value for tegra_output_probe().
> Given that the driver deals with it properly, there's no need to output
> a warning that may potentially confuse users.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/gpu/drm/tegra/sor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
> index e88a17c2937f..5a232055b8cc 100644
> --- a/drivers/gpu/drm/tegra/sor.c
> +++ b/drivers/gpu/drm/tegra/sor.c
> @@ -3765,7 +3765,7 @@ static int tegra_sor_probe(struct platform_device *pdev)
>
> err = tegra_output_probe(&sor->output);
> if (err < 0) {
> - dev_err(&pdev->dev, "failed to probe output: %d\n", err);
> + dev_err_probe(&pdev->dev, "failed to probe output: %d\n", err);
> return err;
> }
Sorry this is not right. I will fix this in V2.
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-03 17:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-03 11:44 [PATCH] drm/tegra: sor: Don't warn on probe deferral Jon Hunter
2020-11-03 17:06 ` Jon Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®