* [PATCH -next] cpumask: use false and true for bool variables
@ 2020-11-09 11:59 Zou Wei
2020-11-09 12:55 ` Peter Zijlstra
2020-11-09 12:58 ` Paul Gortmaker
0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2020-11-09 11:59 UTC (permalink / raw)
To: paul.gortmaker, paulmck, peterz, akpm, abelits
Cc: pjt, jinyuqi, linux-kernel, Zou Wei
Fix coccicheck warnings:
./lib/cpumask.c:342:6-13: WARNING: Comparison of 0/1 to bool variable
./lib/cpumask.c:351:33-40: WARNING: Comparison of 0/1 to bool variable
./lib/cpumask.c:406:3-11: WARNING: Assignment of 0/1 to bool variable
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
lib/cpumask.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/cpumask.c b/lib/cpumask.c
index 34ecb30..74d0cf1 100644
--- a/lib/cpumask.c
+++ b/lib/cpumask.c
@@ -339,7 +339,7 @@ static int find_nearest_node(int *node_dist, bool *used)
/* Choose the first unused node to compare */
for (i = 0; i < nr_node_ids; i++) {
- if (used[i] == 0) {
+ if (used[i] == false) {
min_dist = node_dist[i];
node_id = i;
break;
@@ -348,7 +348,7 @@ static int find_nearest_node(int *node_dist, bool *used)
/* Compare and return the nearest node */
for (i = 0; i < nr_node_ids; i++) {
- if (node_dist[i] < min_dist && used[i] == 0) {
+ if (node_dist[i] < min_dist && used[i] == false) {
min_dist = node_dist[i];
node_id = i;
}
@@ -403,7 +403,7 @@ unsigned int cpumask_local_spread(unsigned int i, int node)
flags);
return cpu;
}
- used[id] = 1;
+ used[id] = true;
}
spin_unlock_irqrestore(&spread_lock, flags);
--
2.6.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] cpumask: use false and true for bool variables
2020-11-09 11:59 [PATCH -next] cpumask: use false and true for bool variables Zou Wei
@ 2020-11-09 12:55 ` Peter Zijlstra
2020-11-09 12:58 ` Paul Gortmaker
1 sibling, 0 replies; 3+ messages in thread
From: Peter Zijlstra @ 2020-11-09 12:55 UTC (permalink / raw)
To: Zou Wei
Cc: paul.gortmaker, paulmck, akpm, abelits, pjt, jinyuqi, linux-kernel
On Mon, Nov 09, 2020 at 07:59:50PM +0800, Zou Wei wrote:
> Fix coccicheck warnings:
>
> ./lib/cpumask.c:342:6-13: WARNING: Comparison of 0/1 to bool variable
> ./lib/cpumask.c:351:33-40: WARNING: Comparison of 0/1 to bool variable
> ./lib/cpumask.c:406:3-11: WARNING: Assignment of 0/1 to bool variable
None of that is a problem, please, apply:
https://lkml.kernel.org/r/20201109113912.GH2594@hirez.programming.kicks-ass.net
and go do something useful.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] cpumask: use false and true for bool variables
2020-11-09 11:59 [PATCH -next] cpumask: use false and true for bool variables Zou Wei
2020-11-09 12:55 ` Peter Zijlstra
@ 2020-11-09 12:58 ` Paul Gortmaker
1 sibling, 0 replies; 3+ messages in thread
From: Paul Gortmaker @ 2020-11-09 12:58 UTC (permalink / raw)
To: Zou Wei, paulmck, peterz, akpm, abelits; +Cc: pjt, jinyuqi, linux-kernel
On 2020-11-09 6:59 a.m., Zou Wei wrote:
> Fix coccicheck warnings:
>
> ./lib/cpumask.c:342:6-13: WARNING: Comparison of 0/1 to bool variable
> ./lib/cpumask.c:351:33-40: WARNING: Comparison of 0/1 to bool variable
> ./lib/cpumask.c:406:3-11: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
It seems "Hulk Robot" needs an AI "tune-up". I didn't touch any of
these lines of code - and I'm guessing they haven't changed in years.
Paul.
--
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> lib/cpumask.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/cpumask.c b/lib/cpumask.c
> index 34ecb30..74d0cf1 100644
> --- a/lib/cpumask.c
> +++ b/lib/cpumask.c
> @@ -339,7 +339,7 @@ static int find_nearest_node(int *node_dist, bool *used)
>
> /* Choose the first unused node to compare */
> for (i = 0; i < nr_node_ids; i++) {
> - if (used[i] == 0) {
> + if (used[i] == false) {
> min_dist = node_dist[i];
> node_id = i;
> break;
> @@ -348,7 +348,7 @@ static int find_nearest_node(int *node_dist, bool *used)
>
> /* Compare and return the nearest node */
> for (i = 0; i < nr_node_ids; i++) {
> - if (node_dist[i] < min_dist && used[i] == 0) {
> + if (node_dist[i] < min_dist && used[i] == false) {
> min_dist = node_dist[i];
> node_id = i;
> }
> @@ -403,7 +403,7 @@ unsigned int cpumask_local_spread(unsigned int i, int node)
> flags);
> return cpu;
> }
> - used[id] = 1;
> + used[id] = true;
> }
> spin_unlock_irqrestore(&spread_lock, flags);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-09 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-09 11:59 [PATCH -next] cpumask: use false and true for bool variables Zou Wei
2020-11-09 12:55 ` Peter Zijlstra
2020-11-09 12:58 ` Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®