* [PATCH] sched/fair: Remove the redundant critical section
@ 2020-11-10 13:41 Qi Zheng
2020-11-10 13:49 ` Vincent Guittot
0 siblings, 1 reply; 2+ messages in thread
From: Qi Zheng @ 2020-11-10 13:41 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman, bristot
Cc: linux-kernel, Qi Zheng
Now there is nothing in the critical section, so remove it.
Signed-off-by: Qi Zheng <arch0.zheng@gmail.com>
---
kernel/sched/fair.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 52cacfc62922..06c4f3430e95 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5114,9 +5114,6 @@ static void do_sched_cfs_slack_timer(struct cfs_bandwidth *cfs_b)
return;
distribute_cfs_runtime(cfs_b);
-
- raw_spin_lock_irqsave(&cfs_b->lock, flags);
- raw_spin_unlock_irqrestore(&cfs_b->lock, flags);
}
/*
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sched/fair: Remove the redundant critical section
2020-11-10 13:41 [PATCH] sched/fair: Remove the redundant critical section Qi Zheng
@ 2020-11-10 13:49 ` Vincent Guittot
0 siblings, 0 replies; 2+ messages in thread
From: Vincent Guittot @ 2020-11-10 13:49 UTC (permalink / raw)
To: Qi Zheng
Cc: Ingo Molnar, Peter Zijlstra, Juri Lelli, Dietmar Eggemann,
Steven Rostedt, Ben Segall, Mel Gorman,
Daniel Bristot de Oliveira, linux-kernel
On Tue, 10 Nov 2020 at 14:41, Qi Zheng <arch0.zheng@gmail.com> wrote:
>
> Now there is nothing in the critical section, so remove it.
https://lkml.org/lkml/2020/10/30/689
>
> Signed-off-by: Qi Zheng <arch0.zheng@gmail.com>
> ---
> kernel/sched/fair.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 52cacfc62922..06c4f3430e95 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5114,9 +5114,6 @@ static void do_sched_cfs_slack_timer(struct cfs_bandwidth *cfs_b)
> return;
>
> distribute_cfs_runtime(cfs_b);
> -
> - raw_spin_lock_irqsave(&cfs_b->lock, flags);
> - raw_spin_unlock_irqrestore(&cfs_b->lock, flags);
> }
>
> /*
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-10 13:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-10 13:41 [PATCH] sched/fair: Remove the redundant critical section Qi Zheng
2020-11-10 13:49 ` Vincent Guittot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®