* [PATCH v2] phy: mapphone-mdm6600: return error when timed out powering up
@ 2020-11-16 9:11 xiakaixu1987
2020-11-16 9:42 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: xiakaixu1987 @ 2020-11-16 9:11 UTC (permalink / raw)
To: kishon, vkoul; +Cc: linux-kernel, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
The value of variable error is overwritten by the following call
devm_request_threaded_irq() in phy_mdm6600_device_power_on(), actually
we should return error when timed out powering up.
Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
v2:
-directly return error when timed out powering.
drivers/phy/motorola/phy-mapphone-mdm6600.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c
index 5172971f4c36..2f461c0d7276 100644
--- a/drivers/phy/motorola/phy-mapphone-mdm6600.c
+++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c
@@ -423,6 +423,7 @@ static int phy_mdm6600_device_power_on(struct phy_mdm6600 *ddata)
ddata->enabled = false;
error = -ETIMEDOUT;
dev_err(ddata->dev, "Timed out powering up\n");
+ return error;
}
/* Reconfigure mode1 GPIO as input for OOB wake */
--
2.20.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] phy: mapphone-mdm6600: return error when timed out powering up
2020-11-16 9:11 [PATCH v2] phy: mapphone-mdm6600: return error when timed out powering up xiakaixu1987
@ 2020-11-16 9:42 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2020-11-16 9:42 UTC (permalink / raw)
To: xiakaixu1987; +Cc: kishon, linux-kernel, Kaixu Xia
On 16-11-20, 17:11, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> The value of variable error is overwritten by the following call
> devm_request_threaded_irq() in phy_mdm6600_device_power_on(), actually
> we should return error when timed out powering up.
>
> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
> ---
> v2:
> -directly return error when timed out powering.
>
> drivers/phy/motorola/phy-mapphone-mdm6600.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c
> index 5172971f4c36..2f461c0d7276 100644
> --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c
> +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c
> @@ -423,6 +423,7 @@ static int phy_mdm6600_device_power_on(struct phy_mdm6600 *ddata)
> ddata->enabled = false;
> error = -ETIMEDOUT;
or drop this
> dev_err(ddata->dev, "Timed out powering up\n");
> + return error;
and do:
return -ETIMEDOUT;
> }
>
> /* Reconfigure mode1 GPIO as input for OOB wake */
> --
> 2.20.0
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-16 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 9:11 [PATCH v2] phy: mapphone-mdm6600: return error when timed out powering up xiakaixu1987
2020-11-16 9:42 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®