From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: "Ma, Jianpeng" <jianpeng.ma@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: bitmap: Remove unused function declaration
Date: Mon, 16 Nov 2020 12:00:46 +0200 [thread overview]
Message-ID: <20201116100046.GS4077@smile.fi.intel.com> (raw)
In-Reply-To: <CAAH8bW_WVomz45dUAth9OqVRe=+nYcBBcc9iW4tmXkDSnJOUhw@mail.gmail.com>
On Sun, Nov 15, 2020 at 07:59:37PM -0800, Yury Norov wrote:
> (CC related people)
>
> Since there is no actual implementation for them, there's , I think
> it's safe (and better)
> to remove the declarations. Thanks for the catch.
Fixes: 2afe27c718b6 ("lib/bitmap.c: bitmap_[empty,full]: remove code duplication")
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Yury Norov <yury.norov@gmail.com>
>
> On Sun, Nov 15, 2020 at 7:17 PM Ma, Jianpeng <jianpeng.ma@intel.com> wrote:
> >
> > Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
> > ---
> > include/linux/bitmap.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> > index 99058eb81042..6f08965c69a5 100644
> > --- a/include/linux/bitmap.h
> > +++ b/include/linux/bitmap.h
> > @@ -126,8 +126,6 @@ extern void bitmap_free(const unsigned long *bitmap);
> > * lib/bitmap.c provides these functions:
> > */
> >
> > -extern int __bitmap_empty(const unsigned long *bitmap, unsigned int nbits);
> > -extern int __bitmap_full(const unsigned long *bitmap, unsigned int nbits);
> > extern int __bitmap_equal(const unsigned long *bitmap1,
> > const unsigned long *bitmap2, unsigned int nbits);
> > extern bool __pure __bitmap_or_equal(const unsigned long *src1,
> > --
> > 2.28.0
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-11-16 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 3:17 Ma, Jianpeng
2020-11-16 3:59 ` Yury Norov
2020-11-16 10:00 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116100046.GS4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=jianpeng.ma@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome